From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: `C-h v' may offer too many symbols Date: Thu, 10 Mar 2011 21:10:35 -0500 Message-ID: References: <87y64mkdu3.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1299809449 9854 80.91.229.12 (11 Mar 2011 02:10:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2011 02:10:49 +0000 (UTC) Cc: Ted Zlatanov , emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 03:10:43 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PxroQ-0008Ko-QP for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2011 03:10:43 +0100 Original-Received: from localhost ([127.0.0.1]:50897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxroQ-0006yI-1v for ged-emacs-devel@m.gmane.org; Thu, 10 Mar 2011 21:10:42 -0500 Original-Received: from [140.186.70.92] (port=42359 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxroL-0006y9-9R for emacs-devel@gnu.org; Thu, 10 Mar 2011 21:10:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxroK-0003xU-7d for emacs-devel@gnu.org; Thu, 10 Mar 2011 21:10:37 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:52175 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxroJ-0003xP-Vg for emacs-devel@gnu.org; Thu, 10 Mar 2011 21:10:36 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAMkTeU3O+IG+/2dsb2JhbACmNHjBZ4ViBIUkkAk X-IronPort-AV: E=Sophos;i="4.62,300,1297054800"; d="scan'208";a="95611664" Original-Received: from 206-248-129-190.dsl.teksavvy.com (HELO ceviche.home) ([206.248.129.190]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 10 Mar 2011 21:10:35 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1F53B66135; Thu, 10 Mar 2011 21:10:35 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Thu, 10 Mar 2011 20:39:48 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137073 Archived-At: > Yes, it is a bit silly complete keywords, which are not variables by > definition. I'm going to install this trivial fix. Sounds good. FWIW, here's a patch I have pending for the lexbind branch (where special-variable-p is t only for vars that have been defvar'd or defconst'd). Stefan === modified file 'lisp/help-fns.el' --- lisp/help-fns.el 2011-03-06 21:22:16 +0000 +++ lisp/help-fns.el 2011-03-11 02:07:37 +0000 @@ -618,8 +618,8 @@ "Describe variable (default %s): " v) "Describe variable: ") obarray - '(lambda (vv) - (or (boundp vv) + (lambda (vv) + (or (special-variable-p vv) (get vv 'variable-documentation))) t nil nil (if (symbolp v) (symbol-name v))))