From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8415: 23.3.50; Extensible Emacs Registers Date: Mon, 04 Apr 2011 10:29:11 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301928274 23883 80.91.229.12 (4 Apr 2011 14:44:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2011 14:44:34 +0000 (UTC) Cc: Davis Herring , 8415@debbugs.gnu.org, Daniel Colascione To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 04 16:44:29 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q6l0p-0001vE-EO for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2011 16:44:23 +0200 Original-Received: from localhost ([127.0.0.1]:43069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6l0E-0002H9-Kv for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2011 10:43:38 -0400 Original-Received: from [140.186.70.92] (port=39205 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6ku5-0006N2-Aw for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2011 10:37:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6ku3-0004MA-2Z for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2011 10:37:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6ku3-0004M6-0y for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2011 10:37:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q6kn5-0002yu-HV; Mon, 04 Apr 2011 10:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2011 14:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8415 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8415-submit@debbugs.gnu.org id=B8415.130192736011394 (code B ref 8415); Mon, 04 Apr 2011 14:30:03 +0000 Original-Received: (at 8415) by debbugs.gnu.org; 4 Apr 2011 14:29:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q6kmO-0002xi-Er for submit@debbugs.gnu.org; Mon, 04 Apr 2011 10:29:20 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q6kmM-0002xU-QT for 8415@debbugs.gnu.org; Mon, 04 Apr 2011 10:29:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAE/VmU1Ld/Y6/2dsb2JhbAClXniIebcEhWsElj8 X-IronPort-AV: E=Sophos;i="4.63,297,1299474000"; d="scan'208";a="103075220" Original-Received: from 75-119-246-58.dsl.teksavvy.com (HELO pastel.home) ([75.119.246.58]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 04 Apr 2011 10:29:11 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8FDDA58DF1; Mon, 4 Apr 2011 10:29:11 -0400 (EDT) In-Reply-To: (Leo's message of "Sun, 03 Apr 2011 20:29:02 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 04 Apr 2011 10:30:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45619 Archived-At: > I would like to propose the following patch that makes the register > system easier to hook into. With this change, for example, if one wants > to make a command to save a keyboard macro to a register. There is no > need to change register.el. 3rd party libraries such as undo-tree.el can > add registers of undo state that one can jump to with C-x r j. Sounds good. > -(defvar register-alist nil > - "Alist of elements (NAME . CONTENTS), one for each Emacs register. > -NAME is a character (a number). CONTENTS is a string, number, marker or list. > +;;; in-memeory persistency Please capitalize your comments and add a closing ".". Why "memeory"? ;-) > +(defvar register-hash-table (make-hash-table)) Why change it to a hash-table? > +;;; immutable register object > +(defstruct > + (register (:constructor nil) > + (:constructor register--make (name &optional value print-func > + jump-func insert-func extra)) > + (:copier nil) > + (:type list) > + :named) > + (name nil :read-only t) > + (value nil :read-only t) > + (print-func nil :read-only t) > + (jump-func nil :read-only t) > + (insert-func nil :read-only t) > + (extra nil :read-only t)) Remove `extra': it's unused, undocumented, and doesn't seem to be any use (there's already `value'). > +VALUE may be a string, number, marker or list. IIUC this is not true any more, it can be any value. > +(define-obsolete-function-alias 'set-register 'register-make "24.1") > +(make-obsolete 'get-register "use `register-find' and `register-value'." "24.1") A more backward-compatible change would be to not use register-structs for pre-existing cases (i.e. markers, strings, lists of string, and win-confs). I.e. only add register structs as a new accepted kind of value (and move `name' out of the struct). The patch would most likely be a lot smaller. Stefan