From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10760: 24.0.93; [patch] Convert artist-mode to use define-minor-mode Date: Wed, 08 Feb 2012 14:25:20 -0500 Message-ID: References: <87fwelztll.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1328729168 31423 80.91.229.3 (8 Feb 2012 19:26:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2012 19:26:08 +0000 (UTC) Cc: 10760@debbugs.gnu.org, tab@lysator.liu.se To: William Stevenson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 08 20:26:06 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RvD9Z-0006kT-15 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2012 20:26:05 +0100 Original-Received: from localhost ([::1]:38266 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvD9Y-0001xc-Hr for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2012 14:26:04 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:46385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvD9U-0001xR-So for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2012 14:26:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvD9T-0004ov-QB for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2012 14:26:00 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvD9T-0004oq-OW for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2012 14:25:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RvDAU-0001Fg-BW for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2012 14:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2012 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10760 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10760-submit@debbugs.gnu.org id=B10760.13287291934763 (code B ref 10760); Wed, 08 Feb 2012 19:27:02 +0000 Original-Received: (at 10760) by debbugs.gnu.org; 8 Feb 2012 19:26:33 +0000 Original-Received: from localhost ([127.0.0.1]:60958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RvDA0-0001El-Or for submit@debbugs.gnu.org; Wed, 08 Feb 2012 14:26:32 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:4522) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RvD9y-0001EV-BS; Wed, 08 Feb 2012 14:26:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AioFALjLMk9MCqD0/2dsb2JhbABDrF6CKoEIgXMBBVYjEAsOJhIUGA0kwVaLdRICAgMGAgQCAQQCAgwGCgMBhB0BBAQegzoEiEabCIRa X-IronPort-AV: E=Sophos;i="4.73,385,1325480400"; d="scan'208";a="162157495" Original-Received: from 76-10-160-244.dsl.teksavvy.com (HELO pastel.home) ([76.10.160.244]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Feb 2012 14:25:21 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id CA17159047; Wed, 8 Feb 2012 14:25:20 -0500 (EST) In-Reply-To: <87fwelztll.fsf@gmail.com> (William Stevenson's message of "Wed, 08 Feb 2012 07:12:38 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:56697 Archived-At: Thank you. > - (defvar artist-mode-map The keymap does not have to be defined within the call to define-minor-mode (actually I recommend you don't do that in general), so you can leave the (defvar artist-mode-map ...) untouched. > ! (defun artist-mode-init () [...] > ! (defun artist-mode-exit () You can also keep these functions. This will significantly reduce the size of your patch and will make it much easier to figure out what is really changed (and hence, whether or not the change is safe). > ! :init-value nil :group 'artist :lighter " Artist" You should use artist-mode-name here. Stefan "who actually prefers `diff -u' format"