From: Stefan Monnier <monnier@iro.umontreal.ca>
To: William Stevenson <yhvh2000@gmail.com>
Cc: 10760@debbugs.gnu.org, tab@lysator.liu.se
Subject: bug#10760: 24.0.93; [patch] Convert artist-mode to use define-minor-mode
Date: Wed, 08 Feb 2012 14:25:20 -0500 [thread overview]
Message-ID: <jwv7gzx875q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fwelztll.fsf@gmail.com> (William Stevenson's message of "Wed, 08 Feb 2012 07:12:38 +0000")
Thank you.
> - (defvar artist-mode-map
The keymap does not have to be defined within the call to
define-minor-mode (actually I recommend you don't do that in general),
so you can leave the (defvar artist-mode-map ...) untouched.
> ! (defun artist-mode-init ()
[...]
> ! (defun artist-mode-exit ()
You can also keep these functions. This will significantly reduce the
size of your patch and will make it much easier to figure out what is
really changed (and hence, whether or not the change is safe).
> ! :init-value nil :group 'artist :lighter " Artist"
You should use artist-mode-name here.
Stefan "who actually prefers `diff -u' format"
next prev parent reply other threads:[~2012-02-08 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 7:12 bug#10760: 24.0.93; [patch] Convert artist-mode to use define-minor-mode William Stevenson
2012-02-08 7:34 ` William Stevenson
2012-02-08 19:25 ` Stefan Monnier [this message]
2012-02-09 4:15 ` William Stevenson
2012-02-09 22:01 ` Stefan Monnier
2012-02-11 2:22 ` William Stevenson
2012-02-13 20:57 ` Stefan Monnier
2012-04-11 11:57 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7gzx875q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=10760@debbugs.gnu.org \
--cc=tab@lysator.liu.se \
--cc=yhvh2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.