From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Roland Winkler" <winkler@gnu.org>
Cc: 11983@debbugs.gnu.org
Subject: bug#11983: 24.1; Electric-command-loop broken?
Date: Thu, 19 Jul 2012 04:40:43 -0400 [thread overview]
Message-ID: <jwv7gu0upar.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87pq7s6b8q.fsf@gnu.org> (Roland Winkler's message of "Wed, 18 Jul 2012 15:54:45 -0500")
> I am trying to understand Electric-command-loop in electric.el
I do not understand what it's trying to do, let alone how it's trying to
do it.
The best I could understand of what it's trying to do is summarized in
the commentary I added:
;; - electric modes and buffers: modes that typically pop-up in a modal kind of
;; way a transient buffer that automatically disappears as soon as the user
;; is done with it.
> (this is used by BBDB 3):
Could you maybe then describe the expected behavior, from the user's
point of view? Adding docstrings, and/or improving comments would be
very welcome.
> - The code contains a hard-coded
> (setq universal-argument-num-events 0)
> Apparently this is never reset, so exiting Electric-command-loop
> leaves behind this binding.
It's a global var used by `universal-argument'.
`universal-argument' is implemented in a rather intricate way, part of
which is actually hidden deep in the C code.
universal-argument-num-events is used for when you finish a C-u sequence
to find which keys are part of the universal argument and which keys are
part of the actual command you wan to run.
`universal-argument' should really use something like
set-temporary-overlay-map instead so it wouldn't need
universal-argument-other-key and neither would it have to fiddle with
unread-command-events.
> - The doc string says
> ;; Given third argument non-nil, it
> ;; INHIBITS quitting unless the user types C-g at toplevel. This is
> ;; so user can do things like C-u C-g and not get thrown out.
> Yet it appears to me, that even for C-u C-g the user gets thrown out.
I have no idea what this "C-u C-g" refers to, indeed.
Stefan
next prev parent reply other threads:[~2012-07-19 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 20:54 bug#11983: 24.1; Electric-command-loop broken? Roland Winkler
2012-07-19 8:40 ` Stefan Monnier [this message]
2012-07-19 21:29 ` Roland Winkler
2012-07-20 9:47 ` Stefan Monnier
2012-07-20 10:43 ` Roland Winkler
2012-07-20 12:09 ` Stefan Monnier
2012-07-20 12:38 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7gu0upar.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11983@debbugs.gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.