From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Date: Thu, 26 Sep 2013 14:05:09 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1380218785 17618 80.91.229.3 (26 Sep 2013 18:06:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 Sep 2013 18:06:25 +0000 (UTC) Cc: 15466@debbugs.gnu.org To: Xue Fuqiao , Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 26 20:06:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VPFxK-0007PV-I0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2013 20:06:26 +0200 Original-Received: from localhost ([::1]:59260 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPFxK-0000sV-3Q for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2013 14:06:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPFx4-0000dC-9G for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 14:06:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPFwx-0004xx-0N for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 14:06:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPFww-0004xt-UA for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 14:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VPFww-0005L3-HG for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 14:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2013 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15466-submit@debbugs.gnu.org id=B15466.138021871320460 (code B ref 15466); Thu, 26 Sep 2013 18:06:02 +0000 Original-Received: (at 15466) by debbugs.gnu.org; 26 Sep 2013 18:05:13 +0000 Original-Received: from localhost ([127.0.0.1]:38462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPFw9-0005Jw-0n for submit@debbugs.gnu.org; Thu, 26 Sep 2013 14:05:13 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:33307) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPFw6-0005Jl-Te for 15466@debbugs.gnu.org; Thu, 26 Sep 2013 14:05:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw/I/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kAYgjwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFG4rw/I/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kAYgjwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="29174868" Original-Received: from 184-175-15-200.dsl.teksavvy.com (HELO pastel.home) ([184.175.15.200]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Sep 2013 14:02:10 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id ACD7C61E0B; Thu, 26 Sep 2013 14:05:09 -0400 (EDT) In-Reply-To: (Xue Fuqiao's message of "Thu, 26 Sep 2013 22:14:54 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78757 Archived-At: > (define-key map (kbd "RET") 'image-next-line) > ;; Zoom in/out. > (define-key map "+" 'doc-view-enlarge) > + (define-key map "=" 'doc-view-enlarge) > + (define-key map (kbd "C-x C-+") 'doc-view-enlarge) > + (define-key map (kbd "C-x C-=") 'doc-view-enlarge) > (define-key map "-" 'doc-view-shrink) > + (define-key map (kbd "C-x C--") 'doc-view-shrink) > ;; Fit the image to the window > (define-key map "W" 'doc-view-fit-width-to-window) > (define-key map "H" 'doc-view-fit-height-to-window) I think it's OK (unless Tassilo disagrees, obviously), but it needs some comments about why it's added (for the = binding, I guess it's because it's the "unshifted +", which for the other it's to override text-scale-adjust). Also, maybe instead of rebinding C-x C-+, we should remap text-scale-adjust. Stefan