From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: 17522@debbugs.gnu.org
Subject: bug#17522: diff-mode frustrates attempt to correct corrupted diff file.
Date: Sun, 25 May 2014 16:18:09 -0400 [thread overview]
Message-ID: <jwv7g59y5st.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <20140525160755.GA2777@acm.acm> (Alan Mackenzie's message of "Sun, 25 May 2014 16:07:55 +0000")
>> diff-mode.el was partly changed to accommodate that looser format, but
>> not 100%.
> Why not?
The usual: lack of time/motivation/...
> If you're going to carry on making surreptitious changes to
> hunk headers, you'll need to determine the start and end of hunks
> reliably, especially corrupted hunks. This can't be done with 100%
> certainty, and is going to involve heuristics. A good way might be to
> scan a hunk _forwards_ counting lines before the first change to that
> hunk.
Exactly, with a before-change-function.
And if the hunk is found to be borked, then try to at least not make
things worse (and maybe suggest the use of diff-sanity-check-hunk, after
we make it into a command).
Stefan
prev parent reply other threads:[~2014-05-25 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 10:50 bug#17522: diff-mode frustrates attempt to correct corrupted diff file Alan Mackenzie
2014-05-19 15:39 ` Glenn Morris
2014-05-20 13:54 ` Stefan Monnier
2014-05-21 21:56 ` Alan Mackenzie
2014-05-22 1:32 ` Stefan Monnier
2014-05-22 21:14 ` Alan Mackenzie
2014-05-23 2:07 ` Stefan Monnier
2014-05-23 20:43 ` Alan Mackenzie
2014-05-24 3:19 ` Stefan Monnier
2014-05-25 16:07 ` Alan Mackenzie
2014-05-25 20:18 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7g59y5st.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17522@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.