From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18039: 24.3; Broken docstring in cl-style functions Date: Sat, 19 Jul 2014 12:50:23 -0400 Message-ID: References: <87vbqwanvi.fsf@gmail.com> <87y4vshlm2.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1405788695 4217 80.91.229.3 (19 Jul 2014 16:51:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Jul 2014 16:51:35 +0000 (UTC) Cc: Thorsten Jolitz , 18039@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 19 18:51:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X8Xqy-0008W5-Pt for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jul 2014 18:51:20 +0200 Original-Received: from localhost ([::1]:55030 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Xqy-00012U-G3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jul 2014 12:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Xqo-00011D-DN for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 12:51:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X8Xqg-0005vW-Rz for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 12:51:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X8Xqg-0005vS-OP for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 12:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X8Xqg-00062j-7g for bug-gnu-emacs@gnu.org; Sat, 19 Jul 2014 12:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jul 2014 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18039-submit@debbugs.gnu.org id=B18039.140578863423197 (code B ref 18039); Sat, 19 Jul 2014 16:51:02 +0000 Original-Received: (at 18039) by debbugs.gnu.org; 19 Jul 2014 16:50:34 +0000 Original-Received: from localhost ([127.0.0.1]:59608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8XqE-000624-AE for submit@debbugs.gnu.org; Sat, 19 Jul 2014 12:50:34 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:39479) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X8Xq9-00061o-Hv for 18039@debbugs.gnu.org; Sat, 19 Jul 2014 12:50:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="78099916" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Jul 2014 12:50:23 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 33D0960BEC; Sat, 19 Jul 2014 12:50:23 -0400 (EDT) In-Reply-To: <87y4vshlm2.fsf@web.de> (Michael Heerdegen's message of "Thu, 17 Jul 2014 02:31:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91666 Archived-At: > The newline character in the (printed) argument list makes a > difference in this expression in help-add-fundoc-usage: > (if (and (stringp arglist) > (string-match "\\`([^ ]+\\(.*\\))\\'" arglist)) > (concat "(fn" (match-string 1 arglist) ")") > (format "%S" (help-make-usage 'fn arglist))) > (help-make-usage doesn't seem to expect a stringp arglist). Should the > regexp given to string-match be changed? Indeed, we have a bug there. We should/could probably arrange for arglist to be on a single line (quote newlines as \n), but we should also make the code more robust such that when the regexp fails to match we signal an error rather than fallback to the non-string case which then burps. Stefan