From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Thorsten Jolitz <tjolitz@gmail.com>, 18039@debbugs.gnu.org
Subject: bug#18039: 24.3; Broken docstring in cl-style functions
Date: Sat, 19 Jul 2014 12:50:23 -0400 [thread overview]
Message-ID: <jwv7g39fg7m.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87y4vshlm2.fsf@web.de> (Michael Heerdegen's message of "Thu, 17 Jul 2014 02:31:17 +0200")
> The newline character in the (printed) argument list makes a
> difference in this expression in help-add-fundoc-usage:
> (if (and (stringp arglist)
> (string-match "\\`([^ ]+\\(.*\\))\\'" arglist))
> (concat "(fn" (match-string 1 arglist) ")")
> (format "%S" (help-make-usage 'fn arglist)))
> (help-make-usage doesn't seem to expect a stringp arglist). Should the
> regexp given to string-match be changed?
Indeed, we have a bug there. We should/could probably arrange for
arglist to be on a single line (quote newlines as \n), but we should
also make the code more robust such that when the regexp fails to match
we signal an error rather than fallback to the non-string case which
then burps.
Stefan
prev parent reply other threads:[~2014-07-19 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 23:24 bug#18039: 24.3; Broken docstring in cl-style functions Thorsten Jolitz
2014-07-17 0:31 ` Michael Heerdegen
2014-07-19 16:50 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7g39fg7m.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=18039@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=tjolitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.