From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19118: 25.0.50; [patch] Change the argument names of function-put (currently: "ARG1 ARG2 ARG3") Date: Thu, 20 Nov 2014 21:56:12 -0500 Message-ID: References: <87d28iksya.fsf@yahoo.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416538656 20338 80.91.229.3 (21 Nov 2014 02:57:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2014 02:57:36 +0000 (UTC) Cc: 19118@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 21 03:57:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrePW-00046V-SI for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 03:57:27 +0100 Original-Received: from localhost ([::1]:38234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrePW-00058g-Cx for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Nov 2014 21:57:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrePF-00057Z-O9 for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 21:57:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XreP8-0003di-9e for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 21:57:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XreP8-0003dQ-63 for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 21:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XreP7-000235-QC for bug-gnu-emacs@gnu.org; Thu, 20 Nov 2014 21:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Nov 2014 02:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19118-submit@debbugs.gnu.org id=B19118.14165385787820 (code B ref 19118); Fri, 21 Nov 2014 02:57:01 +0000 Original-Received: (at 19118) by debbugs.gnu.org; 21 Nov 2014 02:56:18 +0000 Original-Received: from localhost ([127.0.0.1]:40075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XreOQ-000224-1E for submit@debbugs.gnu.org; Thu, 20 Nov 2014 21:56:18 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:50657) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XreON-00021u-I7 for 19118@debbugs.gnu.org; Thu, 20 Nov 2014 21:56:15 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sAL2uDco008010; Thu, 20 Nov 2014 21:56:13 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id D300A6626B; Thu, 20 Nov 2014 21:56:12 -0500 (EST) In-Reply-To: <87d28iksya.fsf@yahoo.fr> (Nicolas Richard's message of "Thu, 20 Nov 2014 12:33:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5131=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5131> : inlines <1551> : streams <1345978> : uri <1835502> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96352 > + > +\(fn FUNCTION PROP VALUE)") I think that the better way to get the right args, is to use a normal docstring, as in the patch below. I can't remember why I used a "defalias docstring" instead. Stefan diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el index 1f8b04e..b1cc0f6 100644 --- a/lisp/emacs-lisp/byte-run.el +++ b/lisp/emacs-lisp/byte-run.el @@ -34,10 +34,11 @@ ;; We don't want people to just use `put' because we can't conveniently ;; hook into `put' to remap old properties to new ones. But for now, there's ;; no such remapping, so we just call `put'. - #'(lambda (f prop value) (put f prop value)) - "Set function F's property PROP to VALUE. + #'(lambda (f prop value) + "Set function F's property PROP to VALUE. The namespace for PROP is shared with symbols. -So far, F can only be a symbol, not a lambda expression.") +So far, F can only be a symbol, not a lambda expression." + (put f prop value))) (function-put 'defmacro 'doc-string-elt 3) (function-put 'defmacro 'lisp-indent-function 2)