all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Cc: 19118@debbugs.gnu.org
Subject: bug#19118: 25.0.50; [patch] Change the argument names of function-put (currently: "ARG1 ARG2 ARG3")
Date: Thu, 20 Nov 2014 21:56:12 -0500	[thread overview]
Message-ID: <jwv7fypb6uy.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87d28iksya.fsf@yahoo.fr> (Nicolas Richard's message of "Thu, 20 Nov 2014 12:33:01 +0100")

> +
> +\(fn FUNCTION PROP VALUE)")

I think that the better way to get the right args, is to use a normal
docstring, as in the patch below.  I can't remember why I used
a "defalias docstring" instead.


        Stefan


diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el
index 1f8b04e..b1cc0f6 100644
--- a/lisp/emacs-lisp/byte-run.el
+++ b/lisp/emacs-lisp/byte-run.el
@@ -34,10 +34,11 @@
   ;; We don't want people to just use `put' because we can't conveniently
   ;; hook into `put' to remap old properties to new ones.  But for now, there's
   ;; no such remapping, so we just call `put'.
-  #'(lambda (f prop value) (put f prop value))
-  "Set function F's property PROP to VALUE.
+  #'(lambda (f prop value)
+      "Set function F's property PROP to VALUE.
 The namespace for PROP is shared with symbols.
-So far, F can only be a symbol, not a lambda expression.")
+So far, F can only be a symbol, not a lambda expression."
+      (put f prop value)))
 (function-put 'defmacro 'doc-string-elt 3)
 (function-put 'defmacro 'lisp-indent-function 2)
 





  parent reply	other threads:[~2014-11-21  2:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 11:33 bug#19118: 25.0.50; [patch] Change the argument names of function-put (currently: "ARG1 ARG2 ARG3") Nicolas Richard
2014-11-20 16:34 ` Eli Zaretskii
2014-11-20 20:12   ` Nicolas Richard
2014-11-21  2:56 ` Stefan Monnier [this message]
2014-11-25 12:57   ` Nicolas Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7fypb6uy.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=19118@debbugs.gnu.org \
    --cc=theonewiththeevillook@yahoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.