From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: 20626@debbugs.gnu.org, asparagus@comcast.net
Subject: bug#20626: Wishlist: M-x shell-command-on-rectangle-region
Date: Mon, 22 Jun 2015 22:02:33 -0400 [thread overview]
Message-ID: <jwv7fqv2no3.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <874mlzweri.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 23 Jun 2015 01:37:53 +0300")
> (defun shell-command-on-region (start end command
> &optional output-buffer replace
> - error-buffer display-error-buffer)
> + error-buffer display-error-buffer
> + region)
> "Execute string COMMAND in inferior shell with region as input.
> Normally display output (if any) in temp buffer `*Shell Command Output*';
> Prefix arg means replace the region with it. Return the exit code of
> @@ -3337,7 +3342,8 @@ (defun shell-command-on-region (start end command
> current-prefix-arg
> current-prefix-arg
> shell-command-default-error-buffer
> - t)))
> + t
> + rectangle-mark-mode)))
Doesn't make sense: if the value determine the use of rectangles, the
arg shouldn't be called `region' but something like `rectangle'.
Notice how kill-ring-save takes a `region' argument and doesn't have any
rectangle-specific code.
I still believe that shell-command-on-region should not have
rectangle-specific code. The current `region-extract-function' does let
you extract the region (rectangular or not) in order to pass it to
a shell command. So you don't need any rectangle-specific code for that
part of shell-command-on-region.
OTOH There is indeed some functionality missing there to let you insert
the output in a rectangular way (whatever that means).
Stefan
next prev parent reply other threads:[~2015-06-23 2:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1119163948.10099018.1432245074823.JavaMail.zimbra@comcast.net>
2015-05-21 22:04 ` bug#20626: Wishlist: M-x shell-command-on-rectangle-region asparagus
2015-05-21 22:47 ` Juri Linkov
2015-06-15 21:45 ` Juri Linkov
2015-06-22 22:37 ` Juri Linkov
2015-06-23 2:02 ` Stefan Monnier [this message]
2015-06-23 22:59 ` Juri Linkov
2015-06-23 23:50 ` Stefan Monnier
2015-06-24 22:27 ` Juri Linkov
2015-06-25 3:45 ` Stefan Monnier
2015-06-25 22:30 ` Juri Linkov
2015-06-26 1:53 ` Stefan Monnier
2015-06-30 20:44 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7fqv2no3.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=20626@debbugs.gnu.org \
--cc=asparagus@comcast.net \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.