Re: [elpa] master a217663: Update copyright exceptions

Re: [elpa] master a217663: Update copyright exceptions

[Stefan Monnier]

Hi Fabián,

Could you tell me how you got this copyright_exceptions update?
It seems like it was done in the wrong locale (the content of the file
is unchanged, really, other than sorting the lines differently), yet the
GNUmakefile explicitly sets LANG=C to try and avoid that.

Please try and figure out what happened, so we can fix the GNUmakefile to
avoid the problem in the future.

...time passes...

Hmm... now I see that I used LANG=C instead of LC_ALL=C, so you probably
had some LC_* setting that took priority over the LANG setting.  I just
fixed GNUmakefile to use LC_ALL=C.

Can you confirm that this was the cause of the problem?


        Stefan


>>>>> "Fabin" == Fabin Ezequiel Gallina <fgallina@gnu.org> writes:

> branch: master
> commit a2176631a7c575fe1b2ab10b67ecb98d3d9dc100
> Author: Fabián Ezequiel Gallina <fgallina@gnu.org>
> Commit: Fabián Ezequiel Gallina <fgallina@gnu.org>

>     Update copyright exceptions
> ---
>  copyright_exceptions |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)

> diff --git a/copyright_exceptions b/copyright_exceptions
> index 95f1b54..1e8413c 100644
> --- a/copyright_exceptions
> +++ b/copyright_exceptions
> @@ -1,20 +1,20 @@
>  ./ada-mode/ada-prj.el
> -./ada-mode/ada-skel.el:    ("copyright_license"
>  ./ada-mode/ada-skel.el:  "--  Copyright (C) " (format-time-string "%Y ") user-full-name " All Rights Reserved.\n"
>  ./ada-mode/ada-skel.el:  "--  Copyright (C) " (format-time-string "%Y ") user-full-name " All Rights Reserved.\n"
> -./ada-mode/ada-skel.el:  "Example copyright/license skeleton, with automatic year and owner, GPLv3."
> +./ada-mode/ada-skel.el:    ("copyright_license"
> +./ada-mode/ada-skel.el:  "{copyright_license}\n"
>  ./ada-mode/ada-skel.el:  "Example copyright/license skeleton, with automatic year and owner."
> +./ada-mode/ada-skel.el:  "Example copyright/license skeleton, with automatic year and owner, GPLv3."
>  ./ada-mode/ada-skel.el:  "Insert a file header comment, with automatic copyright year and prompt for copyright owner/license.
> -./ada-mode/ada-skel.el:  "{copyright_license}\n"
>  ./ada-mode/ada-stmt.el
>  ./ada-mode/ada-xref.el
> -./ada-mode/gpr-skel.el:    ("copyright_license"
>  ./ada-mode/gpr-skel.el:  "--  Copyright (C) " (format-time-string "%Y ") user-full-name " All Rights Reserved.\n"
>  ./ada-mode/gpr-skel.el:  "--  Copyright (C) " (format-time-string "%Y ") user-full-name " All Rights Reserved.\n"
> -./ada-mode/gpr-skel.el:  "Example copyright/license skeleton, with automatic year and owner, GPLv3."
> +./ada-mode/gpr-skel.el:    ("copyright_license"
> +./ada-mode/gpr-skel.el:  "{copyright_license}\n"
>  ./ada-mode/gpr-skel.el:  "Example copyright/license skeleton, with automatic year and owner."
> +./ada-mode/gpr-skel.el:  "Example copyright/license skeleton, with automatic year and owner, GPLv3."
>  ./ada-mode/gpr-skel.el:  "Insert a file header comment, with automatic copyright year and prompt for copyright owner/license.
> -./ada-mode/gpr-skel.el:  "{copyright_license}\n"
>  ./auctex/latex.el:   "pounds" "copyright"
>  ./auctex/multi-prompt.el
>  ./auctex/plain-tex.el:   "copyright"
> @@ -35,10 +35,10 @@
>  ./auctex/style/german.el
>  ./auctex/style/graphics.el
>  ./auctex/style/j-article.el
> -./auctex/style/j-book.el
> -./auctex/style/j-report.el
>  ./auctex/style/jarticle.el
> +./auctex/style/j-book.el
>  ./auctex/style/jbook.el
> +./auctex/style/j-report.el
>  ./auctex/style/jreport.el
>  ./auctex/style/jsarticle.el
>  ./auctex/style/jsbook.el

Re: [elpa] master a217663: Update copyright exceptions

[Fabián Ezequiel Gallina]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hi Fabián,
>
> Could you tell me how you got this copyright_exceptions update?
> It seems like it was done in the wrong locale (the content of the file
> is unchanged, really, other than sorting the lines differently), yet the
> GNUmakefile explicitly sets LANG=C to try and avoid that.
>
> Please try and figure out what happened, so we can fix the GNUmakefile to
> avoid the problem in the future.
>
> ...time passes...
>
> Hmm... now I see that I used LANG=C instead of LC_ALL=C, so you probably
> had some LC_* setting that took priority over the LANG setting.  I just
> fixed GNUmakefile to use LC_ALL=C.
>
> Can you confirm that this was the cause of the problem?
>

Hi Stefan,

Oh I missed that, sorry!

Yes, that seems to be it. I tried the latest `make check_copyrights` and
it reported no changes with the reverted copyright_exceptions file.

For reference these are my locale settings:

  LANG=en_US.UTF-8
  LANGUAGE=en_US:en
  LC_CTYPE="en_US.UTF-8"
  LC_NUMERIC="en_US.UTF-8"
  LC_TIME="en_US.UTF-8"
  LC_COLLATE="en_US.UTF-8"
  LC_MONETARY="en_US.UTF-8"
  LC_MESSAGES="en_US.UTF-8"
  LC_PAPER="en_US.UTF-8"
  LC_NAME="en_US.UTF-8"
  LC_ADDRESS="en_US.UTF-8"
  LC_TELEPHONE="en_US.UTF-8"
  LC_MEASUREMENT="en_US.UTF-8"
  LC_IDENTIFICATION="en_US.UTF-8"
  LC_ALL=en_US.UTF-8


Thanks,
Fabián.

Re: [elpa] master a217663: Update copyright exceptions

[Nicolas Richard]

fgallina@gnu.org (Fabián Ezequiel Gallina) writes:
> For reference these are my locale settings:
>[...]
>   LC_ALL=en_US.UTF-8

I think LC_ALL should generally remain unset : it overrides all others.

-- 
Nico.