From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: markkarpov@openmailbox.org, 21329-done@debbugs.gnu.org
Subject: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros
Date: Sat, 29 Aug 2015 11:31:35 -0400 [thread overview]
Message-ID: <jwv7foeun8y.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83613z4k5a.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Aug 2015 16:28:33 +0300")
>> One possible problem is that input-pending-p might return t in cases where
>> the pending input is "not significant", in the sense that read-event
>> won't return it (maybe because it will consume it internally as in the
>> case of event bounds to special-event-map, IIRC).
> I thought about ignoring out these kinds of input in the loop that
> waits.
Then you have another side-effect, which is to delay the processing of
those events. So instead of ignoring them it should process them.
That's why I think we'd want to "simply" extract all that read-event
does upto (not not including) the actual consumption (and return) of
the event.
>> PS: I suggest you try and install your suggested patch, in the
>> mean time. I don't understand enough of its impact to judge its
>> quality, but it's worth a try. Just make sure you add a good comment in
>> the code explaining the problem this is trying to fix.
> Done.
> I'm therefore closing this bug.
Thanks,
Stefan
next prev parent reply other threads:[~2015-08-29 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 11:57 bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Mark Karpov
2015-08-24 14:39 ` Eli Zaretskii
2015-08-25 13:15 ` Stefan Monnier
2015-08-25 15:26 ` Eli Zaretskii
2015-08-25 16:31 ` Eli Zaretskii
2015-08-25 22:23 ` Stefan Monnier
2015-08-26 2:44 ` Eli Zaretskii
2015-08-28 1:33 ` Stefan Monnier
2015-08-28 13:28 ` Eli Zaretskii
2015-08-29 15:31 ` Stefan Monnier [this message]
2015-08-29 16:22 ` Eli Zaretskii
2015-08-30 2:06 ` Stefan Monnier
2015-08-30 2:08 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7foeun8y.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=21329-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=markkarpov@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.