all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 0f3c1db: Changed semantics of first-undoable-change-hook.
Date: Wed, 30 Sep 2015 20:22:12 -0400	[thread overview]
Message-ID: <jwv7fn7h26w.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <87io6rsj4k.fsf@russet.org.uk> (Phillip Lord's message of "Wed, 30 Sep 2015 22:16:27 +0100")

> Hmmm. So, I had a look at this, and it's actually more complex than it
> appears. The problem, ironically, is the bundling in
> Fself_insert_command. My code (first-undoable-change-hook) only runs on
> the first change after a boundary. And this doesn't mean "after a
> boundary has been added" but "when there is a boundary on the head of
> the list immediately after a change has happened". But,
> self-insert-command removes this boundary. So my hook doesn't run. At

Clearly, remove_excessive_undo_boundaries (and related state like
last-undo-boundary) will need to be fully rewritten, and it will
inevitably be very dependent on the rest of *your* code.  I think we can
move it to Elisp and make it part of your code (it can, and even has to,
be deeply dependent on the rest of your code).  So it can run the hook
by hand, if needed.


        Stefan



      reply	other threads:[~2015-10-01  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150928134935.25048.30653@vcs.savannah.gnu.org>
     [not found] ` <E1ZgYoB-0006Wc-Vz@vcs.savannah.gnu.org>
2015-09-29  5:35   ` [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change 0f3c1db: Changed semantics of first-undoable-change-hook Stefan Monnier
2015-09-30 21:16     ` Phillip Lord
2015-10-01  0:22       ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7fn7h26w.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.