From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 c23c965: Prevent bootstrap autoload backup files Date: Tue, 12 Apr 2016 09:30:49 -0400 Message-ID: References: <20160412114621.17612.69908@vcs.savannah.gnu.org> <87bn5fkmx2.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1460467880 19196 80.91.229.3 (12 Apr 2016 13:31:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Apr 2016 13:31:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 12 15:31:13 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1apyPQ-0005ul-N3 for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2016 15:31:12 +0200 Original-Received: from localhost ([::1]:49571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apyPK-0005kJ-Uj for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2016 09:31:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apyPD-0005g0-1V for emacs-devel@gnu.org; Tue, 12 Apr 2016 09:31:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apyP9-0006w6-5G for emacs-devel@gnu.org; Tue, 12 Apr 2016 09:30:58 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apyP8-0006vd-4W for emacs-devel@gnu.org; Tue, 12 Apr 2016 09:30:54 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u3CDUnpY010520; Tue, 12 Apr 2016 09:30:50 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id B6744AE67F; Tue, 12 Apr 2016 09:30:49 -0400 (EDT) In-Reply-To: <87bn5fkmx2.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 12 Apr 2016 13:54:17 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5640=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5640> : inlines <4667> : streams <1618165> : uri <2185349> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202866 Archived-At: >>>>> "Phillip" == Phillip Lord writes: > Stefan Monnier writes: >>> - (let ((delay-mode-hooks t)) >>> - (find-file-noselect >>> - (autoload-ensure-default-file (autoload-generated-file)))))) >>> + (let* ((delay-mode-hooks t) >>> + (file (autoload-generated-file)) >>> + (file-missing (not (file-exists-p file)))) >>> + (when file-missing >>> + (autoload-ensure-default-file file)) >>> + (with-current-buffer >>> + (find-file-noselect >>> + (autoload-ensure-file-writeable >>> + file)) >>> + ;; block backups when the file has just been created, since >>> + ;; the backups will just be the auto-generated headers. >>> + ;; bug#23203 >>> + (when file-missing >>> + (setq buffer-backed-up t) >>> + (save-buffer)) >>> + (current-buffer))))) >> >> That looks quite complicated just to suppress backups. >> Could you explain why we couldn't just do something like: >> >> (let ((delay-mode-hooks t) >> (make-backup-files)) >> (find-file-noselect >> (autoload-ensure-default-file (autoload-generated-file)))))) >> or >> (let ((delay-mode-hooks t)) >> (with-current-buffer >> (find-file-noselect >> (autoload-ensure-default-file (autoload-generated-file))) >> (setq-local backup-inhibited t))))) > It has different semantics. My patch preserves backup files except when > the autoload file is created for the first time. This only happens > because we create the header and footer in one place, then reopen with > find-file-noselect. I see. Yuck! And thanks for the explanation. Stefan