From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106) Date: Tue, 28 Mar 2017 09:55:26 -0400 Message-ID: References: <20170328002231.12647.93735@vcs0.savannah.gnu.org> <20170328002231.E5CCC220D2@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490709354 8662 195.159.176.226 (28 Mar 2017 13:55:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 13:55:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Noam Postavsky To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 15:55:50 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csrb4-0001Df-T8 for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 15:55:43 +0200 Original-Received: from localhost ([::1]:53461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csrbA-0004O3-Pm for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 09:55:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csrb5-0004Ny-A4 for emacs-devel@gnu.org; Tue, 28 Mar 2017 09:55:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csrb1-00041R-69 for emacs-devel@gnu.org; Tue, 28 Mar 2017 09:55:43 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:28380) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csrb1-000410-1q for emacs-devel@gnu.org; Tue, 28 Mar 2017 09:55:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A6BgABa9pY/14zq8BdHQEFAQsBg1SFAItQkF0pAZcwhhwEAgKDIEQUAQIBAQEBAQEBayiFFgEEAVYjBQsLNBIUGA2KNgivA4pNAQEBBwImiz2FIIUZAQSJF4gXizKUM4hnhmiTajYhgQQkFggsQYUOgWYkiiIBAQE X-IPAS-Result: A0A6BgABa9pY/14zq8BdHQEFAQsBg1SFAItQkF0pAZcwhhwEAgKDIEQUAQIBAQEBAQEBayiFFgEEAVYjBQsLNBIUGA2KNgivA4pNAQEBBwImiz2FIIUZAQSJF4gXizKUM4hnhmiTajYhgQQkFggsQYUOgWYkiiIBAQE X-IronPort-AV: E=Sophos;i="5.36,236,1486443600"; d="scan'208";a="300282325" Original-Received: from 192-171-51-94.cpe.pppoe.ca (HELO pastel.home) ([192.171.51.94]) by smtp.teksavvy.com with ESMTP; 28 Mar 2017 09:55:26 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1295662C51; Tue, 28 Mar 2017 09:55:26 -0400 (EDT) In-Reply-To: <20170328002231.E5CCC220D2@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Mon, 27 Mar 2017 20:22:31 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213448 Archived-At: > Don't add `search-failed' to ignored errors in info.el (Bug#6106) Good, thanks. > - (signal 'search-failed (list "\n\^_")))) > + (user-error "Search failed: `\n\^_'"))) This one doesn't look like a user-error: the \n\^_ sequence is internal to Info files and mostly invisible to the user, so either we change the text so as to report the message in user-understandable terms, or we keep this as a (signal 'search-failed' ...). Stefan