From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Noam Postavsky <npostavs@gmail.com>
Subject: Re: [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106)
Date: Tue, 28 Mar 2017 09:55:26 -0400 [thread overview]
Message-ID: <jwv7f3933uz.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170328002231.E5CCC220D2@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Mon, 27 Mar 2017 20:22:31 -0400 (EDT)")
> Don't add `search-failed' to ignored errors in info.el (Bug#6106)
Good, thanks.
> - (signal 'search-failed (list "\n\^_"))))
> + (user-error "Search failed: `\n\^_'")))
This one doesn't look like a user-error: the \n\^_ sequence is internal
to Info files and mostly invisible to the user, so either we change the
text so as to report the message in user-understandable terms, or we
keep this as a (signal 'search-failed' ...).
Stefan
next parent reply other threads:[~2017-03-28 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170328002231.12647.93735@vcs0.savannah.gnu.org>
[not found] ` <20170328002231.E5CCC220D2@vcs0.savannah.gnu.org>
2017-03-28 13:55 ` Stefan Monnier [this message]
2017-03-28 14:19 ` [Emacs-diffs] master a62437d: Don't add `search-failed' to ignored errors in info.el (Bug#6106) Noam Postavsky
2017-03-28 14:54 ` Stefan Monnier
2017-03-29 1:26 ` Noam Postavsky
2017-03-31 4:06 ` Mark Oteiza
2017-03-31 14:17 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7f3933uz.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.