From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20852: [PATCH] Warn about missing backslashes during load Date: Mon, 01 May 2017 13:59:33 -0400 Message-ID: References: <20170501142718.3510-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493661616 9507 195.159.176.226 (1 May 2017 18:00:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 May 2017 18:00:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Philipp Stephani , 20852@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 01 20:00:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5FcI-0002Ka-I0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 20:00:10 +0200 Original-Received: from localhost ([::1]:55296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5FcM-0005Vm-ST for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 14:00:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5FcH-0005T4-8q for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:00:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5FcB-0001vY-PG for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:00:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51699) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5FcB-0001vO-MT for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5FcA-0007wY-Hy for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 14:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2017 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug wontfix Original-Received: via spool by 20852-submit@debbugs.gnu.org id=B20852.149366158330480 (code B ref 20852); Mon, 01 May 2017 18:00:02 +0000 Original-Received: (at 20852) by debbugs.gnu.org; 1 May 2017 17:59:43 +0000 Original-Received: from localhost ([127.0.0.1]:49898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5Fbr-0007vY-AK for submit@debbugs.gnu.org; Mon, 01 May 2017 13:59:43 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:25305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5Fbo-0007vJ-Lq for 20852@debbugs.gnu.org; Mon, 01 May 2017 13:59:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CWBwBMdgdZ/3Z8oWxdGgEBAQECAQEBAQgBAQEBg1WFCIVahX+RBQGVQYIPHIYCBAIChDpCFgECAQEBAQEBAWsohRYGViMQCw4mEhQYDSSKMrBGiw0BAQEHAiaLWIpIAQSdU5UThTeDMjOGQJJpgUQmByqBCi4gCC5EhHEcgX8kiSwBAQE X-IPAS-Result: A0CWBwBMdgdZ/3Z8oWxdGgEBAQECAQEBAQgBAQEBg1WFCIVahX+RBQGVQYIPHIYCBAIChDpCFgECAQEBAQEBAWsohRYGViMQCw4mEhQYDSSKMrBGiw0BAQEHAiaLWIpIAQSdU5UThTeDMjOGQJJpgUQmByqBCi4gCC5EhHEcgX8kiSwBAQE X-IronPort-AV: E=Sophos;i="5.37,401,1488862800"; d="scan'208";a="309799710" Original-Received: from 108-161-124-118.dsl.teksavvy.com (HELO ceviche.home) ([108.161.124.118]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 01 May 2017 13:59:33 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8C6AB662E0; Mon, 1 May 2017 13:59:33 -0400 (EDT) In-Reply-To: <20170501142718.3510-1-phst@google.com> (Philipp Stephani's message of "Mon, 1 May 2017 16:27:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132168 Archived-At: Looks great, thank you very much. See comments below. > + if (c == '(' || c == ')' || c == '[' || c == ']' > + || c == '"' || c == ';') These are indeed the most important ones w.r.t elisp-mode's syntax-table, but I think we should put #, ?, and ' in there as well. This said, maybe we should add chars in there "little by little" to try and not overwhelm people with warnings. So the above set might actually be a good set with which to start. > + doc: /* List of deprecated unescaped character literals encountered by `read'. For internal use only. */); Please keep the first line of docstrings with 80 columns. I.e. move the "For internal use only." to a second line. Stefan