all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Proposal: move write-contents-functions higher up in basic-save-buffer
Date: Wed, 24 May 2017 08:29:31 -0400	[thread overview]
Message-ID: <jwv7f16bfud.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87poeyyht2.fsf@ericabrahamsen.net

> I probably just did a poor job writing the initial message. That's what
> I was proposing to begin with: to jiggle `basic-save-buffer' (and I
> think also `save-some-buffers') so that the running of
> `write-contents-functions' comes earlier in the function, or is
> otherwise in its own branch that doesn't require a `buffer-file-name'. I
> think it would be a fairly unintrusive change, it would just require a
> bit of thought. I can try to produce a patch, if this is acceptable in
> principle.

I haven't looked at basic-save-buffer recently, but in the worst case we
could keep the current code and add a

    (if (null buffer-file-name)
        (run-hook-... 'write-contents-functions)
      ...)

but admittedly, it's better if we can move the single call to
write-contents-functions so it's shared by the file and the
non-file cases.


        Stefan




  reply	other threads:[~2017-05-24 12:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23  7:19 Proposal: move write-contents-functions higher up in basic-save-buffer Eric Abrahamsen
2017-05-23  7:25 ` Eric Abrahamsen
2017-05-23 18:41   ` Eli Zaretskii
2017-05-23 18:39 ` Eli Zaretskii
2017-05-23 23:09   ` Eric Abrahamsen
2017-05-24  2:38     ` Eli Zaretskii
2017-05-24  4:55       ` Eric Abrahamsen
2017-05-24 12:29         ` Stefan Monnier [this message]
2017-05-25  7:42           ` Eric Abrahamsen
2017-05-24 17:46         ` Eli Zaretskii
2017-05-24 14:12     ` Richard Stallman
2017-05-28 10:12     ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7f16bfud.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.