From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent. Date: Wed, 12 Jul 2017 14:10:56 -0400 Message-ID: References: <20170712170703.22088.69111@vcs0.savannah.gnu.org> <20170712170705.8D71A22E12@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499883078 29228 195.159.176.226 (12 Jul 2017 18:11:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Jul 2017 18:11:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Alan Mackenzie To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 12 20:11:13 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVM6O-0006wi-Ee for ged-emacs-devel@m.gmane.org; Wed, 12 Jul 2017 20:11:08 +0200 Original-Received: from localhost ([::1]:55115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVM6Q-0001CR-LE for ged-emacs-devel@m.gmane.org; Wed, 12 Jul 2017 14:11:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVM6K-0001Ax-CH for emacs-devel@gnu.org; Wed, 12 Jul 2017 14:11:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVM6H-0001Bq-26 for emacs-devel@gnu.org; Wed, 12 Jul 2017 14:11:04 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:50981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVM6G-0001Aa-Qx for emacs-devel@gnu.org; Wed, 12 Jul 2017 14:11:00 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v6CIAuV0001255; Wed, 12 Jul 2017 14:10:57 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 952A2660B0; Wed, 12 Jul 2017 14:10:56 -0400 (EDT) In-Reply-To: <20170712170705.8D71A22E12@vcs0.savannah.gnu.org> (Alan Mackenzie's message of "Wed, 12 Jul 2017 13:07:04 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6070=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6070> : inlines <5977> : streams <1753898> : uri <2461518> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216554 Archived-At: > +(defmacro c-set-keymap-parent (map parent) > + (cond > + ;; XEmacs > + ((cc-bytecomp-fboundp 'set-keymap-parents) > + `(set-keymap-parents ,map ,parent)) > + ;; Emacs > + ((cc-bytecomp-fboundp 'set-keymap-parent) > + `(set-keymap-parent ,map ,parent)) > + ;; incompatible > + (t (error "CC Mode is incompatible with this version of Emacs")))) All versions of Emacs I can think of have `set-keymap-parent`, including Emacs-19 and XEmacs. Why not just always use `set-keymap-parent`? Stefan