From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes Date: Wed, 11 Oct 2017 16:32:53 -0400 Message-ID: References: <20171008231448.29638.520@vcs0.savannah.gnu.org> <20171008231451.3FBBC20326@vcs0.savannah.gnu.org> <20171011200212.GA7384@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507754000 18144 195.159.176.226 (11 Oct 2017 20:33:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Oct 2017 20:33:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Gemini Lasswell , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 11 22:33:16 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2Ngp-0004Il-PC for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 22:33:15 +0200 Original-Received: from localhost ([::1]:42578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2Ngx-0000jP-2O for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 16:33:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2NgJ-0000j9-Kb for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:32:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2NgG-0003bc-8e for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:32:43 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:50717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2NgG-0003b3-2g for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:32:40 -0400 Original-Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v9BKWcbr005077; Wed, 11 Oct 2017 16:32:38 -0400 Original-Received: by lechazo.home (Postfix, from userid 20848) id AE5E260577; Wed, 11 Oct 2017 16:32:53 -0400 (EDT) In-Reply-To: <20171011200212.GA7384@ACM> (Alan Mackenzie's message of "Wed, 11 Oct 2017 20:02:12 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6134=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6134> : inlines <6125> : streams <1766833> : uri <2514974> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219390 Archived-At: > You don't say why you want to make the patch. No, indeed. I think the patch speaks for itself, and the author of the original code seems to agree. > It looks to me like you want to replace a normal abnormal hook with > a single function. This is less flexible (unless one jumps through > hoops). Look at the patch again: the resulting code is simpler. And if you want, you can reimplement the previous edebug-after-instrumentation-functions API on top of the new, because it's actually *more* flexible. > It is also incompatible; it will break applications which use the > existing interface. Yes, it changes a hook which was introduced what 3 days ago? I promise I'll take care of the all backlash from all the previous users. > I'm against this incompatible change Duly noted. > (which I don't fully understand). I had noticed, yes ;-) Stefan