From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master cfa7c4e: Add missing file gited-ci.el Date: Sat, 19 May 2018 14:57:12 -0400 Message-ID: References: <20180519034013.18440.57172@vcs0.savannah.gnu.org> <20180519034014.37DF720468@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1526756143 17184 195.159.176.226 (19 May 2018 18:55:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 19 May 2018 18:55:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 19 20:55:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fK70y-0004Df-Ou for ged-emacs-devel@m.gmane.org; Sat, 19 May 2018 20:55:36 +0200 Original-Received: from localhost ([::1]:44053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fK730-0001gx-PC for ged-emacs-devel@m.gmane.org; Sat, 19 May 2018 14:57:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fK72d-0001Zr-EZ for emacs-devel@gnu.org; Sat, 19 May 2018 14:57:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fK72a-0002Ip-Dk for emacs-devel@gnu.org; Sat, 19 May 2018 14:57:19 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:56273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fK72a-0002IW-8d for emacs-devel@gnu.org; Sat, 19 May 2018 14:57:16 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w4JIvCee015244; Sat, 19 May 2018 14:57:12 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1003062ED5; Sat, 19 May 2018 14:57:12 -0400 (EDT) In-Reply-To: <20180519034014.37DF720468@vcs0.savannah.gnu.org> (Tino Calancha's message of "Fri, 18 May 2018 23:40:13 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 3 Rules triggered ATR_WMN=0.2, EDT_SA_DN_PASS=0, RV6289=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6289> : inlines <6645> : streams <1787213> : uri <2644018> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225452 Archived-At: > +;;; gited-ci.el --- Obtain CI status of the trunk branch -*- lexical-binding:t -*- > +;; This is missing the copyright and licence blurbs. > +(defcustom gited-show-trunk-ci-status nil > + "Show CI status for the last commit in the trunk branch. > +An alist of conses ((TOPLEVEL_DIR_1 . CI-URI_1) (TOPLEVEL_DIR_2 . CI-URI_2) ... ). I usually prefer to say ... a list of elements of the form (TOPLEVEL-DIR . CI-URI) ... So you don't need to talk about the "_I" thingy. But other than this mostly irrelevant nitpick, I have a more serious comment to make: why not rely on dir-locals variable for that? Stefan