From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master cfa7c4e: Add missing file gited-ci.el Date: Sun, 20 May 2018 09:38:26 -0400 Message-ID: References: <20180519034013.18440.57172@vcs0.savannah.gnu.org> <20180519034014.37DF720468@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1526823450 31305 195.159.176.226 (20 May 2018 13:37:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 May 2018 13:37:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 20 15:37:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKOWb-00083O-Ia for ged-emacs-devel@m.gmane.org; Sun, 20 May 2018 15:37:25 +0200 Original-Received: from localhost ([::1]:46601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKOYi-0002Cf-Ep for ged-emacs-devel@m.gmane.org; Sun, 20 May 2018 09:39:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKOXf-00024S-Su for emacs-devel@gnu.org; Sun, 20 May 2018 09:38:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKOXc-0002qB-Qj for emacs-devel@gnu.org; Sun, 20 May 2018 09:38:31 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:42920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKOXc-0002pp-M6 for emacs-devel@gnu.org; Sun, 20 May 2018 09:38:28 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w4KDcimG007714; Sun, 20 May 2018 09:38:44 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 0659569A46; Sun, 20 May 2018 09:38:26 -0400 (EDT) In-Reply-To: (Tino Calancha's message of "Sun, 20 May 2018 12:10:59 +0900 (JST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 3 Rules triggered ATR_WMN=0.2, EDT_SA_DN_PASS=0, RV6289=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6289> : inlines <6645> : streams <1787287> : uri <2644378> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225471 Archived-At: >> This is missing the copyright and licence blurbs. > Fixed in commit 'gited-ci.el: Fix copyright stuff' Thanks. I hadn't noticed that the blurb was just further down, sorry. >> But other than this mostly irrelevant nitpick, I have a more serious >> comment to make: why not rely on dir-locals variable for that? > Never used dir-locals before. I need to study such stuff first :-) Another option is to store this data inside the .git/config (i.e. either use Emacs's standard way to set variables per-directory or use Git's way to do the same per-repository). Stefan