From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] master cfa7c4e: Add missing file gited-ci.el
Date: Sun, 20 May 2018 09:38:26 -0400 [thread overview]
Message-ID: <jwv7eny30ww.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1805201203510.3949@calancha-pc> (Tino Calancha's message of "Sun, 20 May 2018 12:10:59 +0900 (JST)")
>> This is missing the copyright and licence blurbs.
> Fixed in commit 'gited-ci.el: Fix copyright stuff'
Thanks. I hadn't noticed that the blurb was just further down, sorry.
>> But other than this mostly irrelevant nitpick, I have a more serious
>> comment to make: why not rely on dir-locals variable for that?
> Never used dir-locals before. I need to study such stuff first :-)
Another option is to store this data inside the .git/config
(i.e. either use Emacs's standard way to set variables per-directory or
use Git's way to do the same per-repository).
Stefan
prev parent reply other threads:[~2018-05-20 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180519034013.18440.57172@vcs0.savannah.gnu.org>
[not found] ` <20180519034014.37DF720468@vcs0.savannah.gnu.org>
2018-05-19 18:57 ` [elpa] master cfa7c4e: Add missing file gited-ci.el Stefan Monnier
2018-05-20 3:10 ` Tino Calancha
2018-05-20 13:38 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7eny30ww.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.