From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#31888: 27.0.50; Segmentation fault in replace-buffer-contents Date: Fri, 29 Jun 2018 10:51:25 -0400 Message-ID: References: <39638875-4e85-85dc-1cfa-3bfb7321e6b0@zoho.com> <83602bq8hl.fsf@gnu.org> <83bmc1vjn8.fsf@gnu.org> <877emnm97t.fsf@gmail.com> <83muvisyqv.fsf@gnu.org> <83efgpofdu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530283829 7418 195.159.176.226 (29 Jun 2018 14:50:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 29 Jun 2018 14:50:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alan Mackenzie , 31888@debbugs.gnu.org, joaotavora@gmail.com, k.michal@zoho.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 29 16:50:25 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYujA-0001nS-Ty for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jun 2018 16:50:25 +0200 Original-Received: from localhost ([::1]:42749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYulG-0005yP-DU for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jun 2018 10:52:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYukp-0005n2-IJ for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2018 10:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYukk-0008FJ-Jg for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2018 10:52:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60325) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYukk-0008Eg-FF for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2018 10:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fYukk-0003m3-3V for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2018 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jun 2018 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31888-submit@debbugs.gnu.org id=B31888.153028389914478 (code B ref 31888); Fri, 29 Jun 2018 14:52:02 +0000 Original-Received: (at 31888) by debbugs.gnu.org; 29 Jun 2018 14:51:39 +0000 Original-Received: from localhost ([127.0.0.1]:39989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYukM-0003lS-Pl for submit@debbugs.gnu.org; Fri, 29 Jun 2018 10:51:38 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:58918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYukI-0003lH-K9 for 31888@debbugs.gnu.org; Fri, 29 Jun 2018 10:51:35 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w5TEq0hg005792; Fri, 29 Jun 2018 10:52:01 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 22FAF660E5; Fri, 29 Jun 2018 10:51:25 -0400 (EDT) In-Reply-To: <83efgpofdu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 29 Jun 2018 17:07:25 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6319=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6319> : inlines <6729> : streams <1791098> : uri <2665941> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147962 Archived-At: > One aspect of the changes for which I'd like some feedback (and CC > Stefan and Alan) is that the modified code no longer calls the > modification hooks for each small insertion or deletion that the > optimized replacement script calls; instead, we call the modification > hooks just once before the series of changes and once after them. I think that's fine. But could we refine the after-change call so it provides tighter bounds than BEGV..ZV (which is worse than what insert-file-contents does, for example)? Stefan