From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#34116: 27.0.50; minibuffer-force-complete-and-exit mostly broken Date: Fri, 18 Jan 2019 08:09:15 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1547816911 15522 195.159.176.226 (18 Jan 2019 13:08:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Jan 2019 13:08:31 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34116@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 18 14:08:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkTsi-0003q2-Kj for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Jan 2019 14:08:20 +0100 Original-Received: from localhost ([127.0.0.1]:39034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTup-0002OU-Nz for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Jan 2019 08:10:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTuj-0002Mc-H3 for bug-gnu-emacs@gnu.org; Fri, 18 Jan 2019 08:10:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkTuV-0001TO-6q for bug-gnu-emacs@gnu.org; Fri, 18 Jan 2019 08:10:18 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkTuM-0001Lr-KZ for bug-gnu-emacs@gnu.org; Fri, 18 Jan 2019 08:10:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gkTuM-00040B-5t for bug-gnu-emacs@gnu.org; Fri, 18 Jan 2019 08:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Jan 2019 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34116-submit@debbugs.gnu.org id=B34116.154781695915324 (code B ref 34116); Fri, 18 Jan 2019 13:10:02 +0000 Original-Received: (at 34116) by debbugs.gnu.org; 18 Jan 2019 13:09:19 +0000 Original-Received: from localhost ([127.0.0.1]:35798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkTtf-0003z6-Eg for submit@debbugs.gnu.org; Fri, 18 Jan 2019 08:09:19 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:60438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkTtc-0003yx-Py for 34116@debbugs.gnu.org; Fri, 18 Jan 2019 08:09:18 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0ID9Fum032171; Fri, 18 Jan 2019 08:09:15 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 146636AB93; Fri, 18 Jan 2019 08:09:15 -0500 (EST) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 18 Jan 2019 12:13:06 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6464=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6464> : inlines <6997> : streams <1810439> : uri <2781846> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154547 Archived-At: > It seems to work most of the times, but I could swear it is > is doing mischief in some situations (can't tell which tho). I can believe it. > Other arguments against it is that it shouldn't be necessary > to query the table again by this point, which is potentially > slow and could have side effects depending on the table. test-completion should be pretty fast (and it's called by the subsequent completion--complete-and-exit so no matter how slow, adding a call cannot slowdown the command by more than a factor 2x). > In other words, there is some arguably poorly chosen cons > juggling going on in minibuffer-force-complete. My fix adds > to that, but at least it stays within the same idiom. I must admit that I find your fix a bit ugly (adding an ad-hoc extra arg, then undoing cycling depending on (and dont-cycle completion-cycling), ...). Taking another look at the problem, I believe the change below is the better option. Any objection? Stefan diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index db8d4ba5ce..879ad9a8f7 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1378,7 +1381,8 @@ completion-all-sorted-completions (defun minibuffer-force-complete-and-exit () "Complete the minibuffer with first of the matches and exit." (interactive) - (minibuffer-force-complete) + (unless completion-cycling + (minibuffer-force-complete)) (completion--complete-and-exit (minibuffer-prompt-end) (point-max) #'exit-minibuffer ;; If the previous completion completed to an element which fails