all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://.
Date: Thu, 27 Jun 2019 19:48:38 -0400	[thread overview]
Message-ID: <jwv7e96r3r0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 20190615033015.46910210EC@vcs0.savannah.gnu.org

> -                 (url-file (url-generic-parse-url (concat "file://" file))
> +                 (url-file (url-generic-parse-url (concat "file:///" file))

So based on this discussion, I guess what this means is that using
a plain `concat` can't be right: for Windows-style name "c:/foo/bar"
we should use `(concat "file:///" file)`, whereas for POSIX-style file
names "/foo/bar" we should use `(concat "file://" file)`.


        Stefan




  parent reply	other threads:[~2019-06-27 23:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190615033014.12012.75126@vcs0.savannah.gnu.org>
     [not found] ` <20190615033015.46910210EC@vcs0.savannah.gnu.org>
2019-06-27 21:57   ` [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file:// Ken Brown
2019-06-27 22:30     ` Juanma Barranquero
2019-06-27 23:37       ` Ken Brown
2019-06-28  1:22         ` Juanma Barranquero
2019-06-28  3:13           ` Ken Brown
2019-06-28  4:08             ` Juanma Barranquero
2019-06-28 12:55               ` Ken Brown
2019-06-28 13:00                 ` Juanma Barranquero
2019-06-28 13:17                   ` Ken Brown
2019-06-28 13:23                     ` Juanma Barranquero
2019-06-28 17:27                       ` Ken Brown
2019-06-27 23:48   ` Stefan Monnier [this message]
2019-06-28  1:25     ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7e96r3r0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.