From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Juri Linkov <juri@linkov.net>
Subject: Re: master 58fde63: * lisp/help-fns.el (describe-variable): Add quotes to symbol value of origval.
Date: Sun, 03 Nov 2019 18:32:39 -0500 [thread overview]
Message-ID: <jwv7e4gk05e.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20191103215233.4860B20A3C@vcs0.savannah.gnu.org> (Juri Linkov's message of "Sun, 3 Nov 2019 16:52:30 -0500 (EST)")
> - (cl-prin1 origval)
> + (if (and (symbolp origval) (not (booleanp origval)))
> + (let* ((rep (cl-prin1-to-string origval))
> + (print-rep (format-message "`%s'" rep)))
> + (insert print-rep))
> + (cl-prin1 origval))
I'd recommend we add a ":" at the end of the preceding text instead.
Avoids any question about whether the quotes are actually part of the
value, and makes copy&paste easier.
Stefan
next parent reply other threads:[~2019-11-03 23:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191103215229.32162.69545@vcs0.savannah.gnu.org>
[not found] ` <20191103215233.4860B20A3C@vcs0.savannah.gnu.org>
2019-11-03 23:32 ` Stefan Monnier [this message]
2019-11-05 21:32 ` master 58fde63: * lisp/help-fns.el (describe-variable): Add quotes to symbol value of origval Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7e4gk05e.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.