From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Date: Fri, 15 Nov 2019 12:30:54 -0500 Message-ID: References: <87mucz98y9.fsf@web.de> <87r22brq3b.fsf@gnus.org> <87eeya9z3z.fsf@web.de> <87imnm4315.fsf@web.de> <87eey9z1mr.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="156396"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 38195@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 18:44:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVfeO-000eVQ-TH for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 18:44:53 +0100 Original-Received: from localhost ([::1]:43036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVfeM-0005m0-Vp for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2019 12:44:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36648) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVfS0-0000kI-IN for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 12:32:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVfRz-0005N4-3O for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 12:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56746) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVfRx-0005Kv-UC for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 12:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVfRx-0002Xj-OH for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 12:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38195 X-GNU-PR-Package: emacs Original-Received: via spool by 38195-submit@debbugs.gnu.org id=B38195.15738390729705 (code B ref 38195); Fri, 15 Nov 2019 17:32:01 +0000 Original-Received: (at 38195) by debbugs.gnu.org; 15 Nov 2019 17:31:12 +0000 Original-Received: from localhost ([127.0.0.1]:37332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVfRA-0002WT-Gl for submit@debbugs.gnu.org; Fri, 15 Nov 2019 12:31:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVfR8-0002WG-HO for 38195@debbugs.gnu.org; Fri, 15 Nov 2019 12:31:11 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A8FF4449D56; Fri, 15 Nov 2019 12:31:04 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6AF92449D47; Fri, 15 Nov 2019 12:31:03 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1573839063; bh=OMtqzgB8pZrCz8OueR9lgUwh2Kb97aKrj6+tj+rjVYc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pCni8Kj77ioQgSgaB3V24eR/qqPLIh0bL2r/94ZaNuAKO9xksT011kEfh+M2vF5hH gzg89UER/ng3AlrNIKxZQzNTMG65YZ+eIGFCrwaoku0ouFZXOmKQNoit56sjlMJfpr iIlNNrTgAsFh5VOlu8kgGstpKvyfwTQrTUVRgtxheEo+rUQQPVz/h206suXxyF2itp 0WKDWUxtPjKYlc8Q0wQjzh9j9PyjImQJlztsFcDfrW+WOT2lKQdt/3FFBGBLnhWRZi ayhncYt8vUZf3hhO1ztbW8qNdjVf3yRheQeWo+9mY7LFLoRoIYP8d5kHBksNVEP/FF NuDI5iyiJKhIw== Original-Received: from pastel (206-248-133-142.dsl.teksavvy.com [206.248.133.142]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F273A121200; Fri, 15 Nov 2019 12:31:02 -0500 (EST) In-Reply-To: <87eey9z1mr.fsf@web.de> (Michael Heerdegen's message of "Fri, 15 Nov 2019 14:54:04 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171680 Archived-At: > All good - but it seems that when you advice a macro, you actually > operate on the expander _function_. Maybe we should speak that out more > clearly? Because that implies that everything you deal with is a > function - e.g. in an :override advice you must specify a function - if > you specify a macro the thing breaks. Right. Currently, this is just implied by the fact that the third argument of `advice-add` is described as "FUNCTION", and that the explanations (in `add-function`) of how this arg is combined with the original definition all use `funcall` and `apply`. I'm not sure how to write the doc to make it more clear, tho (largely because it's just too obvious to me that it's the only way it can work), so if you have a suggestion, fell free to send it. Stefan