From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.diffs,gmane.emacs.devel Subject: Re: master 724af76 2/2: Fix sxhash-equal on bytecodes, markers, etc. Date: Tue, 07 Jan 2020 15:06:09 -0500 Message-ID: References: <20200107192947.22465.82501@vcs0.savannah.gnu.org> <20200107192950.02DA2211A5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51792"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert , emacs-diffs@gnu.org, emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Tue Jan 07 21:06:26 2020 Return-path: Envelope-to: gnu-emacs-diffs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iov7R-000BTO-Gp for gnu-emacs-diffs@m.gmane.org; Tue, 07 Jan 2020 21:06:25 +0100 Original-Received: from localhost ([::1]:55614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iov7Q-0004Xf-CU for gnu-emacs-diffs@m.gmane.org; Tue, 07 Jan 2020 15:06:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60808) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iov7L-0004VI-On for emacs-diffs@gnu.org; Tue, 07 Jan 2020 15:06:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iov7K-0005zd-SL for emacs-diffs@gnu.org; Tue, 07 Jan 2020 15:06:19 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18982) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iov7I-0005w5-8C; Tue, 07 Jan 2020 15:06:16 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B33AA44DA4A; Tue, 7 Jan 2020 15:06:15 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8AB8E44D8E5; Tue, 7 Jan 2020 15:06:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1578427574; bh=jHE7rOZYVeec9S+E+6hQ8TIRpAPT7I1NFz8y3pfh5/w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IFQtbeyl2sDDt4UgiZdmroBm3jxF+kIpPbyMu76qxVX/eWrRABTPSPncKEjTR6Cv9 C9U2BZNSFHxLtortJYG/hteC/Km4CJSEys1A95dbzkCFQQqMqROWW5D/qWTQ814abq cFV0vYGSuUeRxLJTl5Tg9M9iNAtiJHnO94RvgdNuz9l9rIHJcSuN9Irn98Ldc4IF1O G0h7/pVDEij18+Ej9fJkox5Y8iFVmWMStjgqdf36ZmQtW2QIZWALmCIF7Iu9l5jihJ GyxeIdvy18K/Y1UXsrSSODpZfA8qa0AJJIa1fMNTtiU73hGEeOaWeI+6a/vbpkNK4R PJCL4tBUXBiyQ== Original-Received: from pastel (unknown [45.72.147.220]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 426D11202CD; Tue, 7 Jan 2020 15:06:14 -0500 (EST) In-Reply-To: (Pip Cet's message of "Tue, 7 Jan 2020 19:36:23 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-diffs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for Emacs changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Original-Sender: "Emacs-diffs" Xref: news.gmane.org gmane.emacs.diffs:154528 gmane.emacs.devel:244099 Archived-At: > Again, I don't think there's any reason for using markers as keys in > an equal-based hash table. But if you do, what you probably meant was > to use an eq-based hash table, and that used to work; now it doesn't. > > (puthash marker value ht) > <...move marker...> > (gethash marker ht) If it hurts don't do that: the same happens with (puthash conscell value ht) <...setcar conscell...> (gethash conscell ht) -- Stefan