From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14120: [Robert Weiner] Emacs history selection non-string arguments causing failures for a long time Date: Sun, 16 Feb 2020 15:55:12 -0500 Message-ID: References: <87fvz9rhqq.fsf@olor.terpri.org> Mime-Version: 1.0 Content-Type: message/rfc822 Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="94290"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 14120@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 16 21:56:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j3Qxc-000OPk-46 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Feb 2020 21:56:16 +0100 Original-Received: from localhost ([::1]:36312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3Qxb-0003fG-73 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Feb 2020 15:56:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42324) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3QxP-0003dp-JM for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 15:56:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3QxO-0003FR-Lw for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 15:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3QxO-0003Ew-GB for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 15:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j3QxO-0007JZ-DC for bug-gnu-emacs@gnu.org; Sun, 16 Feb 2020 15:56:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87fvz9rhqq.fsf@olor.terpri.org> Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Feb 2020 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14120 X-GNU-PR-Package: emacs Original-Received: via spool by 14120-submit@debbugs.gnu.org id=B14120.158188652428071 (code B ref 14120); Sun, 16 Feb 2020 20:56:02 +0000 Original-Received: (at 14120) by debbugs.gnu.org; 16 Feb 2020 20:55:24 +0000 Original-Received: from localhost ([127.0.0.1]:37761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3Qwl-0007Ig-Vh for submit@debbugs.gnu.org; Sun, 16 Feb 2020 15:55:24 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j3Qwj-0007IS-D6 for 14120@debbugs.gnu.org; Sun, 16 Feb 2020 15:55:22 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ACDF680DE8; Sun, 16 Feb 2020 15:55:15 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1C34880917; Sun, 16 Feb 2020 15:55:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1581886514; bh=9lP02JiU3Xq4rveAmQipJ6qUYWwwha52g+PKVCa5egI=; h=From:To:Subject:Date:From; b=X+00O2r8WNW5IeVM8R/uqEqIfwz/vAIglc8lZ9k6/d5M1IKczKeWnz/CO7BJSiBFg vpqpVwV+GTCA6mnrxcM396eY7KIx2FCCg2Vr5+Rq+YnNw/yH2Pm0XadOrXIzkd9hX8 HBtY9P2yFOQGMNlVQdeftFsJ6rZp7tKtUuQ1T/fYZRGdF8QMdV3P1nxKDBcn30Fb5K kOc2RERtRgOvanBIR6gmK0YnQcGlOxExr34RRPvKgsQ6sL4gMckIzsV8vrAvb2PXBV SP16Z3qV+YlgxiV9PFEtq+Ij9r3TNAeapYRC+Bkg+BR+Iv5uirF8xj3laUpBVMJbmB 6Gvmn6Bet8Bnw== Original-Received: from alfajor (unknown [157.52.14.222]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CF6C512040F; Sun, 16 Feb 2020 15:55:13 -0500 (EST) Content-Disposition: inline X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176128 Archived-At: From: Robert Weiner Date: Sun, 16 Feb 2020 01:14:48 -0500 Subject: Emacs history selection non-string arguments causing failures for a long time To: Stefan Monnier Cc: 14120@debbugs.gnu.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Stefan: This bug #14120 in subr.el is still occurring in Emacs 27.0.50 because leading entries like (require . info) rather than strings are being injected into the history. Since this has affected people for quite a while, I hope you or someone else can add this one line change to the Emacs 27 branch and resolve it. Bob --------- *** subr-old.el 2020-02-16 01:05:56.000000000 -0500 --- subr.el 2020-02-16 01:06:28.000000000 -0500 *************** *** 4490,4496 **** (load-elt (and loads (car loads)))) (save-match-data (while (and loads ! (or (null (car load-elt)) (not (string-match file-regexp (car load-elt))))) (setq loads (cdr loads) load-elt (and loads (car loads))))) --- 4490,4499 ---- (load-elt (and loads (car loads)))) (save-match-data (while (and loads ! ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=14120 ! ;; Avoid this bug still occuring in Emacs 27.0.50 by checking ! ;; if load-elt is a string or not. ! (or (not (stringp (car load-elt))) (not (string-match file-regexp (car load-elt))))) (setq loads (cdr loads) load-elt (and loads (car loads))))) --==-=-=--