From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master b8062be 3/5: Remove some compat code from eudc-bob.el Date: Sat, 15 Aug 2020 08:56:05 -0400 Message-ID: References: <20200812175454.4839.92908@vcs0.savannah.gnu.org> <20200812175456.C5D122172E@vcs0.savannah.gnu.org> <874kp7lpda.fsf@gnus.org> <87mu2zhssl.fsf@gnus.org> <83imdmn0vr.fsf@gnu.org> <835z9mmy4t.fsf@gnu.org> <83364qmr7f.fsf@gnu.org> <83zh6yl7wr.fsf@gnu.org> <83y2mil619.fsf@gnu.org> <83tux5lq43.fsf@gnu.org> <87bljdblir.fsf@gnus.org> <83mu2xldkh.fsf@gnu.org> <83k0y1lca6.fsf@gnu.org> <87sgco1bhq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32653"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 15 17:23:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6y1P-0008Nz-Dx for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 17:23:03 +0200 Original-Received: from localhost ([::1]:50082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6y1O-0002h7-EV for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 11:23:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6xzx-0000M8-UW for emacs-devel@gnu.org; Sat, 15 Aug 2020 11:21:33 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6xzw-0002ZX-Dc; Sat, 15 Aug 2020 11:21:33 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C8B2C80EC2; Sat, 15 Aug 2020 08:56:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E66DF809C8; Sat, 15 Aug 2020 08:56:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1597496166; bh=/JfcrnVZYxAjNIo6d1RhvkF+Urv/W1WsJjyhMetucR4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EYeDu7E+i/M2uYUVYg8o1ltdnAdQwaMVjbnwEmTDifzNAo/MtdtYufPoo0fg6AKGq ktFz6k1IZl9jL1WmZbYHXQ/U0ELU0kgpJlwdABY4nCcIjTFjB/7eOLLpPmJotPysEP ThmYXncOUU0c3tVqRbe4X6cXXkhYol6qlA6MgnZ9COjY9DJAGtM/YMBkwaMaLRGhim xld3FK2q7rIcHYdegPpIyi23uefwFdEqnbtkB4C+Y20dk4WiwS1pLObIqJhfYbOiW3 VgN18yI7OyTynjwsDoUFfCUH9ix5gD24SMR7oY03U4KDCaykpmTFDXe0y76mbMAFfW b/AFmedZumZlw== Original-Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD1301207EB; Sat, 15 Aug 2020 08:56:06 -0400 (EDT) In-Reply-To: <87sgco1bhq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 15 Aug 2020 11:53:21 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/15 08:51:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253799 Archived-At: >>> > Yeah, setting buffer-file-coding-system here is nonsensical, I think? >>> > buffer-file-coding-system is something you set if you have characters in >>> > the buffer, but a unibyte buffer contains only bytes, so no coding system >>> > conversion will be done when saving the buffer, I'd always assumed? >>> >>> Precisely. >> >> Well, modulo the EOL conversion, as discussed. > > Oh, so then it is needed... which is unfortunate. But that explains > all that (let ((coding-system-for-write 'binary)) ...) code all over > Emacs. :-) There's a case to be made that coding-systems shouldn't affect unibyte data at all (i.e. not even EOL). Whether we could do it without introducing too much breakage (and whether we should do it) is unclear to me. Stefan