Re: master 701ed2e 2/2: Use lexical binding in fortran.el

Re: master 701ed2e 2/2: Use lexical binding in fortran.el

[Stefan Monnier]

>     Use lexical binding in fortran.el
[...]
>    (eval                         ;I hate `eval', but it's hard to avoid it here.
> -   '(syntax-propertize-rules
> +   `(syntax-propertize-rules
>       ("^[CcDd\\*]" (0 "<"))
>       ;; We mark all chars after line-length as "comment-start", rather than
>       ;; just the first one.  This is so that a closing ' that's past the
>       ;; line-length will indeed be ignored (and will result in a string that
>       ;; leaks into subsequent lines).
> -     ((format "^[^CcDd\\*\t\n].\\{%d\\}\\(.+\\)" (1- line-length))
> +     (,(format "^[^CcDd\\*\t\n].\\{%d\\}\\(.+\\)" (1- line-length))
>        (1 "<")))))

Hmm... you say "Use lexical binding" yet the above code uses dynamic
binding (since the second arg of `eval` is nil).


        Stefan

Re: master 701ed2e 2/2: Use lexical binding in fortran.el

[Mattias Engdegård]

22 okt. 2020 kl. 17.29 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

> Hmm... you say "Use lexical binding" yet the above code uses dynamic
> binding (since the second arg of `eval` is nil).

Thank you, rectified.