From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: project--files-in-directory: code formatting Date: Wed, 04 Nov 2020 10:44:41 -0500 Message-ID: References: <0751c421-d860-2d79-74ee-52806d46fc13@inventati.org> <2b0f8de5-4202-8056-2c39-94802027f8c5@inventati.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10083"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Manuel Uberti Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 04 16:46:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaKzI-0002Xg-GB for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 16:46:16 +0100 Original-Received: from localhost ([::1]:42490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaKzH-0002j1-FU for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 10:46:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaKxt-0001At-1q for emacs-devel@gnu.org; Wed, 04 Nov 2020 10:44:50 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaKxq-0002uf-Sp for emacs-devel@gnu.org; Wed, 04 Nov 2020 10:44:48 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 276D680662; Wed, 4 Nov 2020 10:44:44 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 982CE80479; Wed, 4 Nov 2020 10:44:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604504682; bh=HKn09c10wAi0tWa/ccyo0hkWrmTAlqLDMSUqik5TvN8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cb+9fT71cmf3rmbHcwQA9vWoWzTwItfGw5sXUEw16l1YbbVfhB0IbRk3Auz7Y6MFV qlRj3N1a2ZuH7JBpWS2uEqZYoiSzael+wOpScDbMesGbjtuY1QNIC1QZG1UBmpcoxn JtNfV5OejIE1KmXLYkCFn5VakyvHG5ZfnEQZkLTGwqzZpCnKqkIM/Ur/csRshMmVB3 0+8jyJ3OCL6/cWlgSG13tuqQDnAV/0Kgq6wpFwxwE+usbiZjvUjZy0JD0EjNYVin4h nyFR7+h8ddRRQNKac+MsYMqNGJAjGQRHtyenlYrw915gAplgGo+zA9xcAMVcRQ85iv th8n/E9Pr6ShQ== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6EA64120310; Wed, 4 Nov 2020 10:44:42 -0500 (EST) In-Reply-To: <2b0f8de5-4202-8056-2c39-94802027f8c5@inventati.org> (Manuel Uberti's message of "Wed, 4 Nov 2020 15:45:59 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/04 09:13:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258680 Archived-At: >> I even added a font-lock rule to highlight such cases in red, but >> apparently that rule doesn't catch this particular case (if you replace >> the empty string with a symbol, it does catch it, tho). > thank you for the prompt reply. I attached a patch for this little change. Thanks, pushed to `master`. > Let me know if I did something wrong or you want me to change something. I tweaked the commit message to better follow our conventions. But more importantly I was very disappointed that the patch doesn't fix the font-lock highlighting ;-) Stefan