all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Manuel Uberti <manuel.uberti@inventati.org>
Cc: emacs-devel@gnu.org
Subject: Re: project--files-in-directory: code formatting
Date: Wed, 04 Nov 2020 10:44:41 -0500	[thread overview]
Message-ID: <jwv7dr1p1p4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <2b0f8de5-4202-8056-2c39-94802027f8c5@inventati.org> (Manuel Uberti's message of "Wed, 4 Nov 2020 15:45:59 +0100")

>> I even added a font-lock rule to highlight such cases in red, but
>> apparently that rule doesn't catch this particular case (if you replace
>> the empty string with a symbol, it does catch it, tho).
> thank you for the prompt reply. I attached a patch for this little change.

Thanks, pushed to `master`.

> Let me know if I did something wrong or you want me to change something.

I tweaked the commit message to better follow our conventions.

But more importantly I was very disappointed that the patch doesn't fix
the font-lock highlighting ;-)


        Stefan




  reply	other threads:[~2020-11-04 15:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 13:26 project--files-in-directory: code formatting Manuel Uberti
2020-11-04 14:30 ` Stefan Monnier
2020-11-04 14:45   ` Manuel Uberti
2020-11-04 15:44     ` Stefan Monnier [this message]
2020-11-07 10:47       ` Andrii Kolomoiets
2020-11-07 15:16         ` Stefan Monnier
2020-11-04 19:40   ` Dmitry Gutov
2020-11-04 21:20     ` Stefan Monnier
2020-11-05  2:25       ` Dmitry Gutov
2020-11-04 18:19 ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7dr1p1p4.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=manuel.uberti@inventati.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.