From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#44023: dired-allow-duplicate-buffers Date: Thu, 05 Nov 2020 10:38:40 -0500 Message-ID: References: <20201015192231.rezuhk7foiyq3uff@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27182"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44023@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 05 16:39:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kahLx-0006yM-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Nov 2020 16:39:10 +0100 Original-Received: from localhost ([::1]:51202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kahLw-0006C8-QV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Nov 2020 10:39:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kahLq-0006Bu-Mi for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 10:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kahLq-0003Zs-Br for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 10:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kahLq-0006dE-8b for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 10:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Nov 2020 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44023 X-GNU-PR-Package: emacs Original-Received: via spool by 44023-submit@debbugs.gnu.org id=B44023.160459073125473 (code B ref 44023); Thu, 05 Nov 2020 15:39:02 +0000 Original-Received: (at 44023) by debbugs.gnu.org; 5 Nov 2020 15:38:51 +0000 Original-Received: from localhost ([127.0.0.1]:53867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kahLf-0006cn-2b for submit@debbugs.gnu.org; Thu, 05 Nov 2020 10:38:51 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kahLc-0006cX-Rr for 44023@debbugs.gnu.org; Thu, 05 Nov 2020 10:38:49 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4397580B69; Thu, 5 Nov 2020 10:38:43 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DA86E80922; Thu, 5 Nov 2020 10:38:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604590721; bh=MnTG2zJnUFyaNfw2VVc0b/EtdTulyIwSlT3tvf4nVto=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jSdo9/xccV9vUpF3qBun+lgSL9g0lPUeScicxuEM9Pumqjg94cCwTIKlgqMuVyB/G N2xU/5IT5PcoLsQCdqmlEVKgX5GkzNJkYvaxp0494luQves0CKVIZTT7khnSeP9T0V HIEjovxJjQqO6nDUbNYwo9XikWg/AoxgNFs+p0WVuE6+fJ1r35VDKJOGDcUJEBe43A 2CAFU0k9cPyIO7yePC9shjtUj9lH9Sy+yaGR+cU81PR2u4o58/5rr2L6q0SwPEiIgG z07JB3U33jjISg9VcqPT2MFQT3HtoBA8D4bPkV4NxpceYr5LB33uhTAxo32MCDZNkT yEPlwWTwoGBVg== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B47E71202AD; Thu, 5 Nov 2020 10:38:41 -0500 (EST) In-Reply-To: <20201015192231.rezuhk7foiyq3uff@E15-2016.optimum.net> (Boruch Baum's message of "Thu, 15 Oct 2020 15:22:31 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192730 Archived-At: > In going through the existing dired code, it seems that some functions > presume that multiple buffers can be visiting the same directory. See: Because of the functionality of Dired (which allows visiting several directories (and subdirectories)) in a single buffer, the code basically "has to" handle that case, indeed (tho I'd be surprised if there aren't improvements to be made in that regard). > +(defcustom dired-allow-duplicate-buffers t [...] > - ;; Look for an existing buffer. > - (buffer (dired-find-buffer-nocreate dirname mode)) > - ;; Note that buffer already is in dired-mode, if found. > + (buffer (when (not (bound-and-true-p dired-allow-duplicate-buffers)) > + ;; Look for an existing buffer. > + (dired-find-buffer-nocreate dirname mode) > + ;; Note that buffer already is in dired-mode, if found. > + )) [ The ";; Note ..." comment seems to be misplaced. ] I wonder if it's better to add a user-config variable or a new argument to `dired-internal-noselect`? E.g. I suspect that diredc wants/needs this feature, but it's not diredc's job to set user options, so for diredc it would probably make more sense to pass that as an argument. WDYT? Stefan