From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Gnus using lexical-binding Date: Tue, 02 Feb 2021 14:40:00 -0500 Message-ID: References: <86k0ruqub2.fsf@gmail.com> <86pn1mz4ni.fsf@gmail.com> <86wnvu80wp.fsf@gmail.com> <874kiu5o6l.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21083"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andy Moreton , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 20:41:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l71YG-0005O0-H6 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 20:41:28 +0100 Original-Received: from localhost ([::1]:57824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l71YF-0005hA-I0 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 14:41:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l71Wy-00058l-C4 for emacs-devel@gnu.org; Tue, 02 Feb 2021 14:40:08 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35585) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l71Wu-0004vN-EX for emacs-devel@gnu.org; Tue, 02 Feb 2021 14:40:07 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3D80E8079A; Tue, 2 Feb 2021 14:40:03 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DED218070D; Tue, 2 Feb 2021 14:40:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612294801; bh=c8sZNZC6pK+0q9Pu3mDyhDpt3U9Z0ZzGQw1UioDirdQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=T+4fKS6jiEnNb+2jZWvANoeUuuRUGtLCzJjSh4bGzb7N+ZTjeSRJ0O8n8BBMIH63J zIyj9/O2TbS2gqZLpHIHc8XSKz7W9roflirBIRr3CaaDrUCaMfWzpev2aMVjV6QjHb Dz2hakP2beLiGdfe+2WWwl/EagHPWygCRabBhQxEW6Og1Hah19Dd3aYbo6Du6G18ht ooXE7qTYPHh8I+DonKMRcYWGUHFGcfk1OQo5vffsSLgx+J/tbdDu6yv9l0DEB8L5N+ OVAGxgM9AOsjP3j/TDHUFsJayt1rZwNjNT72Sa+De5acOdL6BWvDyhjaKCU435huj+ o+m5Yb1tQrnWw== Original-Received: from alfajor (76-10-182-85.dsl.teksavvy.com [76.10.182.85]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 92FD3120125; Tue, 2 Feb 2021 14:40:01 -0500 (EST) In-Reply-To: <874kiu5o6l.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 02 Feb 2021 10:17:54 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263746 Archived-At: > I'm now seeing a bug with `gnus-article-browse-html-article' that might > (?) be a result of this, I'm not sure. It's triggered by the recent change, indeed. It's due to a longer standing bug, tho. The problem is in these two chunks of code in `gnus-art.el`: (let ((gnus-visible-headers (or (get 'gnus-visible-headers 'standard-value) gnus-visible-headers))) (article-hide-headers)) and (let ((gnus-visible-headers (or (get 'gnus-visible-headers 'standard-value) gnus-visible-headers)) (gnus-mime-display-attachment-buttons-in-header nil) ;; As we insert a
, there's no need for the body boundary. (gnus-treat-body-boundary nil)) (gnus-summary-show-article))) I'm not completely sure why this code looks up the `standard-value`, but the `standard-value` property is supposed to contain a cons cell whose car is an *expression* that needs to be evaluated to get the variable's intended standard value. So it will never be nil and using it as a value is just wrong. I installed a patch into `master` which should hopefully fix the problem. Stefan