From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org
Subject: Re: Gnus using lexical-binding
Date: Tue, 02 Feb 2021 14:40:00 -0500 [thread overview]
Message-ID: <jwv7dnqmg85.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874kiu5o6l.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 02 Feb 2021 10:17:54 -0800")
> I'm now seeing a bug with `gnus-article-browse-html-article' that might
> (?) be a result of this, I'm not sure.
It's triggered by the recent change, indeed.
It's due to a longer standing bug, tho.
The problem is in these two chunks of code in `gnus-art.el`:
(let ((gnus-visible-headers
(or (get 'gnus-visible-headers 'standard-value)
gnus-visible-headers)))
(article-hide-headers))
and
(let ((gnus-visible-headers (or (get 'gnus-visible-headers 'standard-value)
gnus-visible-headers))
(gnus-mime-display-attachment-buttons-in-header nil)
;; As we insert a <hr>, there's no need for the body boundary.
(gnus-treat-body-boundary nil))
(gnus-summary-show-article)))
I'm not completely sure why this code looks up the `standard-value`, but
the `standard-value` property is supposed to contain a cons cell whose
car is an *expression* that needs to be evaluated to get the variable's
intended standard value.
So it will never be nil and using it as a value is just wrong.
I installed a patch into `master` which should hopefully fix
the problem.
Stefan
next prev parent reply other threads:[~2021-02-02 19:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 23:11 Gnus using lexical-binding Stefan Monnier
2021-01-30 6:34 ` Lars Ingebrigtsen
2021-01-30 8:35 ` Eli Zaretskii
2021-01-30 13:43 ` Stefan Kangas
2021-01-30 13:52 ` Eli Zaretskii
2021-01-30 14:08 ` Eli Zaretskii
2021-01-30 15:24 ` Stefan Monnier
2021-01-30 15:07 ` Basil L. Contovounesios
2021-01-30 17:40 ` Stefan Monnier
2021-02-08 19:10 ` Ted Zlatanov
2021-02-09 0:10 ` Stefan Monnier
2021-02-10 10:24 ` Ted Zlatanov
2021-02-10 13:53 ` Stefan Monnier
2021-02-10 19:05 ` Lars Ingebrigtsen
2021-01-30 16:10 ` Andy Moreton
2021-01-30 17:35 ` Stefan Monnier
2021-01-30 18:00 ` Andy Moreton
2021-01-30 18:53 ` Stefan Monnier
2021-01-30 23:23 ` Andy Moreton
2021-01-31 0:06 ` Stefan Monnier
2021-01-31 0:46 ` Andy Moreton
2021-01-31 13:34 ` Basil L. Contovounesios
2021-02-02 18:17 ` Eric Abrahamsen
2021-02-02 19:40 ` Stefan Monnier [this message]
2021-02-02 20:31 ` Eric Abrahamsen
2021-01-31 9:13 ` David Engster
2021-01-31 22:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7dnqmg85.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.