From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Pip Cet <pipcet@gmail.com>
Cc: 46834@debbugs.gnu.org
Subject: bug#46834: 28.0.50; byte-compiling the standard counter closure fails
Date: Mon, 01 Mar 2021 09:23:48 -0500 [thread overview]
Message-ID: <jwv7dmrrm5e.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAOqdjBcBtU=HH22EZiz_NBRyMSpKzRvbJ7SJNRwN=TMzek-F7A@mail.gmail.com> (Pip Cet's message of "Sun, 28 Feb 2021 20:34:36 +0000")
> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> index a2fe37a1ee586..7d00b453caf1c 100644
> --- a/lisp/emacs-lisp/bytecomp.el
> +++ b/lisp/emacs-lisp/bytecomp.el
> @@ -2785,16 +2785,12 @@ byte-compile--reify-function
> (dolist (binding env)
> (cond
> ((consp binding)
> - ;; We check shadowing by the args, so that the `let' can be moved
> - ;; within the lambda, which can then be unfolded. FIXME: Some of those
> - ;; bindings might be unused in `body'.
> - (unless (memq (car binding) args) ;Shadowed.
> - (push `(,(car binding) ',(cdr binding)) renv)))
> + (push `(,(car binding) ',(cdr binding)) renv))
> ((eq binding t))
> (t (push `(defvar ,binding) body))))
> (if (null renv)
> `(lambda ,args ,@preamble ,@body)
> - `(lambda ,args ,@preamble (let ,(nreverse renv) ,@body)))))
> + `(let ,renv (lambda ,args ,@preamble ,@body)))))
This looks good, thanks, but it changes the nature of the output of
`byte-compile` from a function value to an expression whose evaluation
returns a function value. So I think we should tweak `byte-compile` so
it calls `eval` on the result in this particular case.
Stefan
next prev parent reply other threads:[~2021-03-01 14:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 15:04 bug#46834: 28.0.50; byte-compiling the standard counter closure fails Pip Cet
2021-02-28 19:57 ` Pip Cet
2021-02-28 20:34 ` Pip Cet
2021-03-01 14:23 ` Stefan Monnier [this message]
2021-03-01 15:01 ` Pip Cet
2021-03-01 16:02 ` Stefan Monnier
2021-03-02 7:00 ` Lars Ingebrigtsen
2021-03-02 7:31 ` Pip Cet
2021-03-02 7:34 ` Lars Ingebrigtsen
2021-03-02 7:36 ` Pip Cet
2021-03-02 13:16 ` Eli Zaretskii
2021-03-02 13:19 ` Pip Cet
2021-03-02 13:48 ` Eli Zaretskii
2021-03-01 13:16 ` Lars Ingebrigtsen
2021-03-01 14:34 ` Stefan Monnier
2021-03-01 15:16 ` Pip Cet
2021-03-01 16:15 ` Stefan Monnier
2021-03-01 16:41 ` Pip Cet
2021-03-01 17:01 ` Stefan Monnier
2021-03-01 17:13 ` Pip Cet
2021-03-01 16:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7dmrrm5e.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=46834@debbugs.gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.