From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: On package-install x package-install-selected-packages Date: Sat, 13 Mar 2021 09:13:59 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7962"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Gabriel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 13 15:18:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL55l-0001yz-3t for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 15:18:09 +0100 Original-Received: from localhost ([::1]:60420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lL55k-0005OM-7A for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 09:18:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL52R-00039g-CL for emacs-devel@gnu.org; Sat, 13 Mar 2021 09:14:44 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL52O-00015K-FT for emacs-devel@gnu.org; Sat, 13 Mar 2021 09:14:42 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3886A44072A; Sat, 13 Mar 2021 09:14:39 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C32DC440412; Sat, 13 Mar 2021 09:14:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615644840; bh=DGK11WM9ILZI4SxhLr3QbD4crklN6nzHDFTxA2bJda0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZU8F04GLKTIfPQkYss2zHS9V2gp9ZoiDwXJlSp+ZpESQiENHEMZ7WhPpcONfq+/2H obnujnONBDXFbfjpY7YDMaJRnDa2xjmLIK+72U9TQzxHxd5AZNSiOeWxovGvAItkfn gNFV4JmyjRCxlEW4XxhJp/ZjxIFFHkw0LJiZQ5uUib05H41leQnfHzaYOr5c3sF3X1 d2wfqYD6D1IjohMb2onZRcdLLe0yzuERc2r67TcUNaFkCl3TgAcDkFGA9nWUDAePVH HLnRuNZvO1dybLNsm/+rnUCmpkmfTeFirVxzz0CzF9L9Qz9LopM1KjpNDGgww6Rhy0 XP2AyJwnH9Qqg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AC09B12016F; Sat, 13 Mar 2021 09:14:00 -0500 (EST) In-Reply-To: (Gabriel's message of "Sat, 13 Mar 2021 03:13:14 -0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266430 Archived-At: > On package.el, the 'package-install' calls > 'package--archives-initialize' to initialize the archive contents, but > 'package-install-selected-packages' does not calls it, relying on users > to initialize the archive contents by themselves. I could not find any > documentation about this difference. Should we modify > 'package-install-selected-packages' to call > 'package--archives-initialize' ? Yes, please. > Or add some flag to control this behavior ? No please. > Also, 'package-install-selected-packages' always asks for a confirmation > to install or not the packages. Can we add an option to skip this > confirmation ? No strong opinion on this one. The confirmation doesn't seem too harmful because I presume it's not a frequent operation, and it takes a while, and it's not necessarily the case that the user knows beforehand what will be installed, but admittedly the prompt only tells how many packages are to be installed, not which ones. Stefan