bug#47152: elpa.gnu.org incompatible with librejs

bug#47152: elpa.gnu.org incompatible with librejs

[email--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

The packages page <https://elpa.gnu.org/packages/>
is blocked by LibreJS because the included javascript
is not clearly licensed. It all appears to be free
jQuery and components related to filtering; it just
needs clear marking.

The page is simple enough that the browsers `C-f` is
sufficient filtering to simply remove the javascript. 
If you want to keep it around <https://melpa.org/jslicense.html>
provides a good example of how to clearly state the
licenses for compatibility with LibreJS.

bug#47152: elpa.gnu.org incompatible with librejs

[Stefan Kangas]

tags 47152 + fixed
close 47152
thanks

email@johnmuhl.me writes:

> The packages page <https://elpa.gnu.org/packages/>
> is blocked by LibreJS because the included javascript
> is not clearly licensed. It all appears to be free
> jQuery and components related to filtering; it just
> needs clear marking.

Thanks.  I have pushed (hopefully working) support for LibreJS to
elpa.git and nongnu.git.

Does anyone know if manual intervention is required to update the pages
for the package list and all individual packages?  Stefan M?

bug#47152: elpa.gnu.org incompatible with librejs

[Stefan Monnier]

> Thanks.  I have pushed (hopefully working) support for LibreJS to
> elpa.git and nongnu.git.
>
> Does anyone know if manual intervention is required to update the pages
> for the package list and all individual packages?  Stefan M?

Yes, manual intervention is needed.  I believe I just did the
necessary copying.  Please confirm,


        Stefan

bug#47152: elpa.gnu.org incompatible with librejs

[Stefan Kangas]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Thanks.  I have pushed (hopefully working) support for LibreJS to
>> elpa.git and nongnu.git.
>>
>> Does anyone know if manual intervention is required to update the pages
>> for the package list and all individual packages?  Stefan M?
>
> Yes, manual intervention is needed.  I believe I just did the
> necessary copying.  Please confirm,

Thanks.  The front page seems to have been updated, but there are two
remaining issues:

1. The "JavaScript license" link seems to be missing in the footer on:

    https://elpa.gnu.org/packages/
    https://elpa.nongnu.org/nongnu/

2. I can't seem to find the jslicense.html file that should be located
   at:

    https://elpa.gnu.org/jslicense.html
    https://elpa.nongnu.org/jslicense.html

(BTW, should elpa.nongnu.org/nongnu/ perhaps be
elpa.nongnu.org/packages/ instead?)

bug#47152: elpa.gnu.org incompatible with librejs

[Stefan Monnier]

>>> Thanks.  I have pushed (hopefully working) support for LibreJS to
>>> elpa.git and nongnu.git.
>>>
>>> Does anyone know if manual intervention is required to update the pages
>>> for the package list and all individual packages?  Stefan M?
>>
>> Yes, manual intervention is needed.  I believe I just did the
>> necessary copying.  Please confirm,
>
> Thanks.  The front page seems to have been updated, but there are two
> remaining issues:
>
> 1. The "JavaScript license" link seems to be missing in the footer on:
>
>     https://elpa.gnu.org/packages/
>     https://elpa.nongnu.org/nongnu/

Hmm...:

    diff index.html .../elpa/html/index.html

gives me nothing.  Should I be looking elsewhere?

> 2. I can't seem to find the jslicense.html file that should be located
>    at:
>
>     https://elpa.gnu.org/jslicense.html
>     https://elpa.nongnu.org/jslicense.html

Sorry.  Should be fixed now.

> (BTW, should elpa.nongnu.org/nongnu/ perhaps be elpa.nongnu.org/packages/ instead?)

I wanted the "nongnu" to be prominent.


        Stefan

bug#47152: elpa.gnu.org incompatible with librejs

[Stefan Kangas]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> 1. The "JavaScript license" link seems to be missing in the footer on:
>>
>>     https://elpa.gnu.org/packages/
>>     https://elpa.nongnu.org/nongnu/
>
> Hmm...:
>
>     diff index.html .../elpa/html/index.html
>
> gives me nothing.  Should I be looking elsewhere?

I believe the package lists are generated by elpa-admin.el, more
specifically `elpaa--html-make-index' that calls the new function
`elpaa--html-footer' where the links are specified.

More specifically, it is this line that matters for LibreJS:

<p><a href=\"/jslicense.html\" data-jslicense=\"1\">JavaScript Licenses</a></p>

bug#47152: elpa.gnu.org incompatible with librejs

[Stefan Monnier]

> I believe the package lists are generated by elpa-admin.el, more
> specifically `elpaa--html-make-index' that calls the new function
> `elpaa--html-footer' where the links are specified.

Ah, I missed that.  I just updated it, so it should get better soon.


        Stefan

bug#47152: elpa.gnu.org incompatible with librejs

[john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Sat, 2021-04-24 at 23:04 -0400, Stefan Monnier wrote:
> > I believe the package lists are generated by elpa-admin.el, more
> > specifically `elpaa--html-make-index' that calls the new function
> > `elpaa--html-footer' where the links are specified.
> 
> Ah, I missed that.  I just updated it, so it should get better soon.
> 
> 
>         Stefan

I guess since the footer is not displayed on individual package pages
those pages are still being flagged by LibreJS. e.g.
https://elpa.gnu.org/packages/ace-window.html

I noticed now that the home, package list and package info pages all
use different footers (well...info pages don't have any footer).