all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#47152: elpa.gnu.org incompatible with librejs
@ 2021-03-15  0:10 email--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-04-21  3:04 ` Stefan Kangas
  0 siblings, 1 reply; 8+ messages in thread
From: email--- via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-03-15  0:10 UTC (permalink / raw)
  To: 47152

The packages page <https://elpa.gnu.org/packages/>
is blocked by LibreJS because the included javascript
is not clearly licensed. It all appears to be free
jQuery and components related to filtering; it just
needs clear marking.

The page is simple enough that the browsers `C-f` is
sufficient filtering to simply remove the javascript. 
If you want to keep it around <https://melpa.org/jslicense.html>
provides a good example of how to clearly state the
licenses for compatibility with LibreJS.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#47152: elpa.gnu.org incompatible with librejs
  2021-03-15  0:10 bug#47152: elpa.gnu.org incompatible with librejs email--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-21  3:04 ` Stefan Kangas
  2021-04-24 14:41   ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2021-04-21  3:04 UTC (permalink / raw)
  To: email; +Cc: 47152, Stefan Monnier

tags 47152 + fixed
close 47152
thanks

email@johnmuhl.me writes:

> The packages page <https://elpa.gnu.org/packages/>
> is blocked by LibreJS because the included javascript
> is not clearly licensed. It all appears to be free
> jQuery and components related to filtering; it just
> needs clear marking.

Thanks.  I have pushed (hopefully working) support for LibreJS to
elpa.git and nongnu.git.

Does anyone know if manual intervention is required to update the pages
for the package list and all individual packages?  Stefan M?





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#47152: elpa.gnu.org incompatible with librejs
  2021-04-21  3:04 ` Stefan Kangas
@ 2021-04-24 14:41   ` Stefan Monnier
  2021-04-24 22:16     ` Stefan Kangas
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2021-04-24 14:41 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: email, 47152

> Thanks.  I have pushed (hopefully working) support for LibreJS to
> elpa.git and nongnu.git.
>
> Does anyone know if manual intervention is required to update the pages
> for the package list and all individual packages?  Stefan M?

Yes, manual intervention is needed.  I believe I just did the
necessary copying.  Please confirm,


        Stefan






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#47152: elpa.gnu.org incompatible with librejs
  2021-04-24 14:41   ` Stefan Monnier
@ 2021-04-24 22:16     ` Stefan Kangas
  2021-04-24 23:28       ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2021-04-24 22:16 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: email, 47152

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Thanks.  I have pushed (hopefully working) support for LibreJS to
>> elpa.git and nongnu.git.
>>
>> Does anyone know if manual intervention is required to update the pages
>> for the package list and all individual packages?  Stefan M?
>
> Yes, manual intervention is needed.  I believe I just did the
> necessary copying.  Please confirm,

Thanks.  The front page seems to have been updated, but there are two
remaining issues:

1. The "JavaScript license" link seems to be missing in the footer on:

    https://elpa.gnu.org/packages/
    https://elpa.nongnu.org/nongnu/

2. I can't seem to find the jslicense.html file that should be located
   at:

    https://elpa.gnu.org/jslicense.html
    https://elpa.nongnu.org/jslicense.html

(BTW, should elpa.nongnu.org/nongnu/ perhaps be
elpa.nongnu.org/packages/ instead?)





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#47152: elpa.gnu.org incompatible with librejs
  2021-04-24 22:16     ` Stefan Kangas
@ 2021-04-24 23:28       ` Stefan Monnier
  2021-04-25  0:03         ` Stefan Kangas
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2021-04-24 23:28 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: email, 47152

>>> Thanks.  I have pushed (hopefully working) support for LibreJS to
>>> elpa.git and nongnu.git.
>>>
>>> Does anyone know if manual intervention is required to update the pages
>>> for the package list and all individual packages?  Stefan M?
>>
>> Yes, manual intervention is needed.  I believe I just did the
>> necessary copying.  Please confirm,
>
> Thanks.  The front page seems to have been updated, but there are two
> remaining issues:
>
> 1. The "JavaScript license" link seems to be missing in the footer on:
>
>     https://elpa.gnu.org/packages/
>     https://elpa.nongnu.org/nongnu/

Hmm...:

    diff index.html .../elpa/html/index.html

gives me nothing.  Should I be looking elsewhere?

> 2. I can't seem to find the jslicense.html file that should be located
>    at:
>
>     https://elpa.gnu.org/jslicense.html
>     https://elpa.nongnu.org/jslicense.html

Sorry.  Should be fixed now.

> (BTW, should elpa.nongnu.org/nongnu/ perhaps be elpa.nongnu.org/packages/ instead?)

I wanted the "nongnu" to be prominent.


        Stefan






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#47152: elpa.gnu.org incompatible with librejs
  2021-04-24 23:28       ` Stefan Monnier
@ 2021-04-25  0:03         ` Stefan Kangas
  2021-04-25  3:04           ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2021-04-25  0:03 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: email, 47152

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> 1. The "JavaScript license" link seems to be missing in the footer on:
>>
>>     https://elpa.gnu.org/packages/
>>     https://elpa.nongnu.org/nongnu/
>
> Hmm...:
>
>     diff index.html .../elpa/html/index.html
>
> gives me nothing.  Should I be looking elsewhere?

I believe the package lists are generated by elpa-admin.el, more
specifically `elpaa--html-make-index' that calls the new function
`elpaa--html-footer' where the links are specified.

More specifically, it is this line that matters for LibreJS:

<p><a href=\"/jslicense.html\" data-jslicense=\"1\">JavaScript Licenses</a></p>





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#47152: elpa.gnu.org incompatible with librejs
  2021-04-25  0:03         ` Stefan Kangas
@ 2021-04-25  3:04           ` Stefan Monnier
  2021-04-29 22:28             ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2021-04-25  3:04 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: email, 47152

> I believe the package lists are generated by elpa-admin.el, more
> specifically `elpaa--html-make-index' that calls the new function
> `elpaa--html-footer' where the links are specified.

Ah, I missed that.  I just updated it, so it should get better soon.


        Stefan






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#47152: elpa.gnu.org incompatible with librejs
  2021-04-25  3:04           ` Stefan Monnier
@ 2021-04-29 22:28             ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 8+ messages in thread
From: john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-29 22:28 UTC (permalink / raw)
  To: 47152

On Sat, 2021-04-24 at 23:04 -0400, Stefan Monnier wrote:
> > I believe the package lists are generated by elpa-admin.el, more
> > specifically `elpaa--html-make-index' that calls the new function
> > `elpaa--html-footer' where the links are specified.
> 
> Ah, I missed that.  I just updated it, so it should get better soon.
> 
> 
>         Stefan

I guess since the footer is not displayed on individual package pages
those pages are still being flagged by LibreJS. e.g.
https://elpa.gnu.org/packages/ace-window.html

I noticed now that the home, package list and package info pages all
use different footers (well...info pages don't have any footer).






^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-04-29 22:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-15  0:10 bug#47152: elpa.gnu.org incompatible with librejs email--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-21  3:04 ` Stefan Kangas
2021-04-24 14:41   ` Stefan Monnier
2021-04-24 22:16     ` Stefan Kangas
2021-04-24 23:28       ` Stefan Monnier
2021-04-25  0:03         ` Stefan Kangas
2021-04-25  3:04           ` Stefan Monnier
2021-04-29 22:28             ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.