From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Zero byte-compiler warnings in the test suite Date: Tue, 21 Dec 2021 10:41:12 -0500 Message-ID: References: <87ilvigl3z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24033"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 21 16:43:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzhIe-00061n-7W for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 16:43:36 +0100 Original-Received: from localhost ([::1]:44082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzhIc-0007BS-8g for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 10:43:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzhGU-0004rh-1z for emacs-devel@gnu.org; Tue, 21 Dec 2021 10:41:22 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzhGQ-00067V-AE for emacs-devel@gnu.org; Tue, 21 Dec 2021 10:41:21 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A6753100221; Tue, 21 Dec 2021 10:41:14 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 58C01100142; Tue, 21 Dec 2021 10:41:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1640101273; bh=VcXyypo3zXqNAGyAcSuZHLLxxAar+WCDxRN5obZtdeA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fyg7geH1m6uCc1+bsUfFC4YFhv9iA9ZoAD24NRWCAbGleSROjLiyCJ6muImgBP6bP nkPtM69mPhSO+Rorv+JpQzB84lbj58O3I4nsJLaz4t4bDDC4nLII4AJN5ppxKrrl1w 7acv7ILtYVTV5h1KCkMcZTVqvyPsESzvd7rHx3cQkJyUmPgdXGvFlHFXUQ+0d2YLyl EuvdRs59L6UCXsvRb+7bFWZ4SD+Q9kjglP6g7XpYyGvsK1MrGAuzN1RqnsFhjCT5wZ OEGkZ6sLFRlsp9T0URpxvCGPE5fst0wOupeILEToyCHvrPuLyL1yQcb8tV+yLQg3Fr SiifCKX/SzyYQ== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 25C241201BE; Tue, 21 Dec 2021 10:41:13 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Tue, 21 Dec 2021 05:39:08 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282598 Archived-At: > Compiler-macro error for cl-typep: (error "Unknown type notatype") > GEN lisp/emacs-lisp/pcase-tests.log > > Grepping for notatype leads me to: > > ./lisp/emacs-lisp/pcase-tests.el:111: ((cl-type > notatype) 'integer)))) > > Does anyone know what is going on here? I thought it was pretty obvious: `c-type` takes a type as argument, but `notatype` is ... not declared as a type, so we get an error. The test expects the error to be signal'd at run time whereas the compiler macro prefers to signal the error right away. As a bias observer, I'd suggest to fix the test rather than the compiler macro ;-) Stefan