From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 99c637499e: Only apply last change to the clipboard Date: Tue, 01 Feb 2022 00:35:42 -0500 Message-ID: References: <164368163944.24305.8528536193885928245@vcs2.savannah.gnu.org> <20220201021359.C439EC40717@vcs2.savannah.gnu.org> <8735l3cg7b.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36335"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 01 06:36:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nElqC-0009FD-9u for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 06:36:32 +0100 Original-Received: from localhost ([::1]:43812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nElqA-0005fv-SY for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Feb 2022 00:36:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nElpV-00050b-Ug for emacs-devel@gnu.org; Tue, 01 Feb 2022 00:35:49 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nElpT-0008Em-CO for emacs-devel@gnu.org; Tue, 01 Feb 2022 00:35:48 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5E20A440238; Tue, 1 Feb 2022 00:35:45 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 18921440D1A; Tue, 1 Feb 2022 00:35:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1643693744; bh=bOLnOJ21woeC4nUlx5r1+NVHz1oGLj1KLsoDJS9GtZk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nLfjBBd3LrcQbNj0kSji45NGQMX1KPw8X5uz85gYb3eUl1CE7wpcsO0zWxqA1bqSG ZK9RTpgwaJJkZmws7gHc5oh84cfBxjpWOXp2MlyIH0oX9Gox9mo/ThcFxmYrJ35l7I ySv/GDtDorC5qAjl9QU5vOhXw4+gNWU1fhIdTH8QBmgZTjb4VrsgpHLbtIr/+iGENG oqMIhk6fe8dIIrxxdUdkw0zZ1was+YCcpTi1yXNJma3et6KM5/w7WpLpyki6q2kBNJ ZiNYzWeABvlfmpPZOgI9vO2ekDwioIS37Ygp5XMxNJJ+puFPTg3O0EJfRN8T84sO1Y FSsbw1QzTkIbA== Original-Received: from pastel (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DEFBE12086B; Tue, 1 Feb 2022 00:35:43 -0500 (EST) In-Reply-To: <8735l3cg7b.fsf@yahoo.com> (Po Lu's message of "Tue, 01 Feb 2022 13:24:08 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285722 Archived-At: >> The comment is weird. Is it meant to apply to the line of code >> *above* it? If so, please move it since we follow the convention to >> put comments *before* the code to which they apply. > > That will be fixed, thanks. > >> Also I suspect that you meant to say `gui-backend-selection-owner-p` >> rather than `gui-backend-selection-p` in the comment, right? > > Yes, thanks. Thanks for confirming. >> BTW rather than use such tests we should probably change >> `gui-backend-selection-owner-p` so it can return yes/no/dontknow. > The problem is that I don't really know why it doesn't work on those > ports. I just observed them returning nonsensical values. Even if we don't know why, it'd be cleaner to put it there than here. Stefan