From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/keycast 809ce7625a: Silence older byte-compilers
Date: Thu, 07 Apr 2022 18:30:19 -0400 [thread overview]
Message-ID: <jwv7d80pm05.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220407195834.9A1E7C009A8@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Thu, 7 Apr 2022 15:58:34 -0400 (EDT)")
> (eval-when-compile
> - (defvar tab-bar-format))
> + (defvar tab-bar-format)
> + (defvar tab-bar-mode))
Please never put those (defvar FOO) within `eval-when-compile`.
AFAICT it has never been needed and only works by accident (it's
arguably a bug).
Stefan
parent reply other threads:[~2022-04-07 22:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220407195834.9A1E7C009A8@vcs2.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7d80pm05.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.