From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Titus von der Malsburg <malsburg@posteo.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 91418d27e9: Add new functions for computing character metrics for windows
Date: Fri, 29 Apr 2022 09:46:33 -0400 [thread overview]
Message-ID: <jwv7d78f1rb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220429131511.9BD62C01683@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 29 Apr 2022 09:15:10 -0400 (EDT)")
Lars Ingebrigtsen [2022-04-29 09:15:10] wrote:
> ++++
> +** New function 'window-max-characters-per-line'.
> +
> ++++
> +** New function 'window-char-pixel-width'.
> +
> ++++
> +** New function 'window-char-pixel-width'.
Any reason not to group them under the same heading?
> + (let* ((face (if face face 'default))
(or face 'default) ?
> + (info (font-info (face-font face)))
> + (width (aref info 11)))
> + (if (> width 0)
> + width
> + (aref info 10)))))
Any chance we could have a `cl-defstruct` for those font-info objects, so
we can use names rather than magic constants? Alternatively a short
comment here explaining the difference between 11 and 10 would be nice.
> +(defun window-max-characters-per-line (&optional window face)
The name says "max", but AFAICT it's basically "window width / *average*
char width", so it's not really the "max" number of chars (unsurprisingly).
I'm not sure how best to name it (and document it), tho.
For that I think I'd need to know what are the use cases (to see what
property they rely on).
Stefan
next parent reply other threads:[~2022-04-29 13:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165123811050.20687.5215165731843845332@vcs2.savannah.gnu.org>
[not found] ` <20220429131511.9BD62C01683@vcs2.savannah.gnu.org>
2022-04-29 13:46 ` Stefan Monnier [this message]
2022-04-29 13:53 ` master 91418d27e9: Add new functions for computing character metrics for windows Lars Ingebrigtsen
2022-04-29 14:55 ` Stefan Monnier
2022-04-29 19:59 ` Eli Zaretskii
2022-04-29 20:40 ` Stefan Monnier
2022-04-30 5:23 ` Eli Zaretskii
2022-04-30 11:12 ` Lars Ingebrigtsen
2022-04-30 13:33 ` Stefan Monnier
2022-04-30 13:48 ` Eli Zaretskii
2022-04-30 14:34 ` Stefan Monnier
2022-04-30 15:25 ` Eli Zaretskii
2022-04-30 15:52 ` Stefan Monnier
2022-04-30 16:19 ` Eli Zaretskii
2022-04-30 21:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7d78f1rb.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=malsburg@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.