From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Thu, 20 Oct 2022 13:04:28 -0400 Message-ID: References: <875yhzmz25.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> <87wn98nlhq.fsf@gnus.org> <87lepo9c1e.fsf@posteo.net> <87r0zfkxzx.fsf@gnus.org> <87pmeyg24x.fsf@posteo.net> <87edvef8nc.fsf@gnus.org> <871qre2l63.fsf@posteo.net> <875ygqf7pc.fsf@gnus.org> <87r0ze15rt.fsf@posteo.net> <871qref5mq.fsf@gnus.org> <875ygohztx.fsf@posteo.net> <83tu489fm6.fsf@gnu.org> <8735bs3ta0.fsf@posteo.net> <87ilkn3jgj.fsf@posteo.net> <87ilkg472a.fsf@posteo.net> <87a65qla8d.fsf@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20765"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 57639@debbugs.gnu.org, Stefan Kangas , larsi@gnus.org, info@protesilaos.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 20 19:05:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1olYzN-0005BL-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Oct 2022 19:05:49 +0200 Original-Received: from localhost ([::1]:49936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olYzA-00067g-32 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Oct 2022 13:05:41 -0400 Original-Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olYyw-0005dS-NO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Oct 2022 13:05:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olYyd-0004dr-Qw for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2022 13:05:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1olYyc-000610-H7 for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2022 13:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1olYyb-0006GO-Uv for bug-gnu-emacs@gnu.org; Thu, 20 Oct 2022 13:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Oct 2022 17:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166628549224057 (code B ref 57639); Thu, 20 Oct 2022 17:05:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 20 Oct 2022 17:04:52 +0000 Original-Received: from localhost ([127.0.0.1]:36055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olYyR-0006Fw-Rk for submit@debbugs.gnu.org; Thu, 20 Oct 2022 13:04:52 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olYyF-0006FY-LA for 57639@debbugs.gnu.org; Thu, 20 Oct 2022 13:04:50 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CD3B780976; Thu, 20 Oct 2022 13:04:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3BB18807AF; Thu, 20 Oct 2022 13:04:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666285472; bh=CyD2CUt6cKaUWSxkmVOpseaij878iwrhkBcODo4/DAs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SQOChr66/d9PdVjYlKdgoaS61UUdLnUBA61SwBby5vE+5wrwDJhjwymScw3jtRiKR ByQLs6lCy6fV+m4J2gEysQ6WYzpH/y2bp+DKV898hKItP5/taHIYDerqnQcDXbj1zM bPCg8RtOGoC3YNYwe8NUYIWs8XbDClWgcntEevnU8PiLtYNRKwDzVybcP4x3aCZ1PO k6yqJfJ6rAuzj77m1/yIG/p4I2jnCtVodU5oP5eZnISgExE+o23RPqay+31RkT8k/Q +N6xnCi68QLPGtZ/IYeHWcdwmnM2tf5V6yYxMWQ4T0JUZmv9V9kJjOR2S6vBOYrIk9 wltFDXfIvc5lQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0E47C120EC8; Thu, 20 Oct 2022 13:04:32 -0400 (EDT) In-Reply-To: <87a65qla8d.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 20 Oct 2022 16:40:18 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245941 Archived-At: >>>> We could arrange for `autoload/loaddefs-gen` to recognize `deftheme` and >>>> add the directory containing the file containing this `deftheme` to the >>>> `custom-theme-load-path`. >>> If this is possible I think this would be a nice idea. >> It should be easy to do. > Sadly I am stumped on how this could be done, as I have little > experience with the bootstrapping process. Could you give me a few pointers? I was thinking of something like the patch below. Stefan diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el index ecc5f7e47bd..a07d0e9ad61 100644 --- a/lisp/emacs-lisp/loaddefs-gen.el +++ b/lisp/emacs-lisp/loaddefs-gen.el @@ -286,8 +286,16 @@ loaddefs-generate--make-autoload ;; Extract theme properties. ((eq car 'deftheme) (let* ((name (car-safe (cdr-safe form))) - (props (nthcdr 3 form))) - `(put ',name 'theme-properties (list ,@props)))) + (props (nthcdr 3 form)) + (dir (file-name-directory file))) + `(progn + (add-to-list 'custom-theme-load-path + ,(if dir + `(expand-file-name ,dir + (file-name-directory + (macroexp-file-name))) + `(file-name-directory (macroexp-file-name)))) + (put ',name 'theme-properties (list ,@props))))) ((eq car 'defgroup) ;; In Emacs this is normally handled separately by cus-dep.el, but for