From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Average-user-facing interface for tree-sitter Date: Thu, 27 Oct 2022 11:21:06 -0400 Message-ID: References: <8BAAB6CC-C8BA-4255-9E60-8963A828BE31@gmail.com> <41838564-B3F1-46C8-A316-EE888C4B9968@gmail.com> <1E3B06A0-46B0-495B-90B0-618CCA5D1C59@gmail.com> <486B2CA9-058E-4842-B9FB-0393F3D5F079@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25929"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Theodor Thornhill , Lars Ingebrigtsen , emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 27 17:22:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo4hv-0006Sz-9a for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Oct 2022 17:22:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo4h0-0002qI-3K; Thu, 27 Oct 2022 11:21:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo4gx-0002KG-Uc for emacs-devel@gnu.org; Thu, 27 Oct 2022 11:21:11 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo4gw-00052U-FW for emacs-devel@gnu.org; Thu, 27 Oct 2022 11:21:11 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 16840440BE3; Thu, 27 Oct 2022 11:21:09 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AFF8B440A90; Thu, 27 Oct 2022 11:21:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666884067; bh=xI0XARYDICKaMgjTPOzpXw0ZNwgcrAK5b4Pfx+q5Ugo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PM63MAk+4SMAdlKHZxobL3mpTDfwF2WzjM9rBw8AaR1801JenLAkgj3sO6KbRa4gu aoEWmc73HYVGB0zD+Za3Frwuih+3Upl3AWIrRHBPCE0C63fhWa2ai2SbLVT9mxMqQR dA/Hc5nOTRPVYvPswezqttJc/z19FOjV1YbhSbVvX58U4OMF6gUE+55ZJj4j+JonCL aFNN/RrIEw1aXOex20dvAIcBuQtuMiYtDniBPQXzJRR91jrCZ4XWkCHN6DmLxfxRVY fPaqRVbZLLdLGP7n0SiE2BHnByQVG3/RiiM6zT2zL51EpVpOBOdAoSS03gwEWkXMnE rIWTZxzgZ4PwA== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 85E47120FA7; Thu, 27 Oct 2022 11:21:07 -0400 (EDT) In-Reply-To: <486B2CA9-058E-4842-B9FB-0393F3D5F079@gmail.com> (Yuan Fu's message of "Wed, 26 Oct 2022 18:56:44 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298624 Archived-At: >> Yes, there are indeed some non-trivial tradeoffs here. > > Reading some old bug report made me realize another problem: what if > a derived-mode of js-mode, A-mode expects cc-mode stuff to be setup by > js-mode, but js-mode doesn=E2=80=99t setup cc-mode because it=E2=80=99s u= sing tree-sitter? > > But if A-mode uses tree-sitter too, then it wouldn=E2=80=99t want js-mode= to setup > cc-mode. So it seems A-mode needs a way to control whether it wants its > parent mode(s) to setup tree-sitter or not. > > One way would be adding another flag in treesit-settings, which controls > whether this mode=E2=80=99s parent should setup tree-sitter. Sounds too hypothetical to make a good decision on what should be done about it. Let's cross that bridge when we get there. In the mean time I think it's perfectly acceptable to say "don't do that if it hurts". Stefan