From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2a7f01aa38: Fix initialization of module functions Date: Thu, 10 Nov 2022 12:44:56 -0500 Message-ID: References: <166807775643.29181.14745596143667535171@vcs2.savannah.gnu.org> <20221110105556.B16E8C0E4C9@vcs2.savannah.gnu.org> <83r0yarfxz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39137"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 18:45:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otBca-0009uV-4i for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 18:45:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otBc1-00083s-Lj; Thu, 10 Nov 2022 12:45:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otBc0-00080F-5d for emacs-devel@gnu.org; Thu, 10 Nov 2022 12:45:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otBbp-00044p-Bf; Thu, 10 Nov 2022 12:45:09 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EAE7D80073; Thu, 10 Nov 2022 12:44:58 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AEC8080436; Thu, 10 Nov 2022 12:44:57 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668102297; bh=xgDkE3s9N05IXBf4AW7A+HHqW+i9OjAxLKOZzuGu/s4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BGupHFXh9xTa3YOpmbgdsCep+5c6pfGn8lfkzy+BDv8mYFfnegkIaDe7Em5TZmlfQ 4TkyvfLF5SB05FNKtbypTpMl/LzzJEJYUEpp8iDFWyZMAIhz/+Os7bXMoPtgthFyu2 Jl560JulafaRB+m/Fj65zbBDDvK0qoBLJG37fICtT7Cx5VLmJhelVmAOIrDUT9ziJk zJv7C34f5nHjQI1ZBO8ggBePNZhF4ciOcN3MIwne/Yss45vZWjWpbPxg7on/18aDmI DlTXCg6OVtE0zZBBzstclTC6UpAnWQYCz/YRdb7x6foTub+SbAc2RTCrI3sqOeEOiF N5HUd3y7s1krg== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8BE33120173; Thu, 10 Nov 2022 12:44:57 -0500 (EST) In-Reply-To: <83r0yarfxz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Nov 2022 17:23:52 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299502 Archived-At: Eli Zaretskii [2022-11-10 17:23:52] wrote: >> From: Stefan Monnier >> Cc: Eli Zaretskii >> Date: Thu, 10 Nov 2022 09:06:35 -0500 >> >> > allocate_module_function (void) >> > { >> > return ALLOCATE_PSEUDOVECTOR (struct Lisp_Module_Function, >> > - interactive_form, PVEC_MODULE_FUNCTION); >> > + command_modes, PVEC_MODULE_FUNCTION); >> > } >> > >> > #define XSET_MODULE_FUNCTION(var, ptr) \ >> >> Usually we accompany that with a comment in the struct stating "this >> is the last GC-tracked field" or something like that. > > There's already such a comment, a few lines above. The comment doesn't say which one is the last tracked field. Stefan