From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, casouri@gmail.com, mickey@masteringemacs.org,
60237@debbugs.gnu.org
Subject: bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node
Date: Fri, 10 Mar 2023 13:28:20 -0500 [thread overview]
Message-ID: <jwv7cvobiy4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv356fxlcj.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 08 Mar 2023 11:34:14 -0500")
>> I tried cargo-culting the cpu_gc_count stuff for the memory profiler,
>> see the patch below. However, something is amiss: this assertion in
>> profiler.el sometimes triggers:
>>
>> (maphash
>> (lambda (backtrace _count)
>> (let* ((max (1- (length backtrace)))
>> (head (aref backtrace max))
>> (best-parent nil)
>> (best-match (1+ max))
>> (parents (gethash head fun-map)))
>> (pcase-dolist (`(,i . ,parent) parents)
>> (when t ;; (<= (- max i) best-match) ;Else, it can't be better.
>> (let ((match max)
>> (imatch i))
>> (cl-assert (>= match imatch)) <<<<<<<<<<<<<<<<<<<<<<<<<<<<
>> (cl-assert (function-equal (aref backtrace max)
>> (aref parent i)))
>>
>> I cannot reliably reproduce this, and don't understand what causes the
>> assertion. Any hints?
>
> Hmm... I just took a look but can't see neither why your change would
> be more likely to trigger this error than the existing code for the
> `cpu` case, nor why this assertion should always be true.
I can imagine corner cases where this could trigger, but they all
involve funny business where we change `profiler-max-stack-depth` during
a single profiling run (I think you'd need to write ad-hoc ELisp code
for that). The only other explanation I can see is that we
somehow end up with a backtrace that includes `Automatic_GC` somewhere
not at the top (maybe this can happen with a `post-gc-hook`?).
If you manage to reproduce it, I'd be interested to know the value of
`backtrace` and `parent` when the assertion fails (and maybe just save
the `log` hash-table so we can look at it). It might be a symptom of
another bug.
And I still can't see how/why this would happen only for the `memory`
profiler and not for the `cpu` profiler, so I assume it can also happen
for the `cpu` profiler and we've just been lucky not to bump into it yet.
This said, I think the patch below should fix it for the `cpu` profiler
and a similar change should fix it for your patch (and the patch is
arguably right in the sense that without this `nil` entry, the backtrace
entry created for `Automatic_GC` is not really complete).
Stefan
diff --git a/src/profiler.c b/src/profiler.c
index 8247b2e90c6..295c47a2acd 100644
--- a/src/profiler.c
+++ b/src/profiler.c
@@ -423,7 +423,7 @@ DEFUN ("profiler-cpu-log", Fprofiler_cpu_log, Sprofiler_cpu_log,
more for our use afterwards since we can't rely on its special
pre-allocated keys anymore. So we have to allocate a new one. */
cpu_log = profiler_cpu_running ? make_log () : Qnil;
- Fputhash (make_vector (1, QAutomatic_GC),
+ Fputhash (CALLN (Fvector, QAutomatic_GC, Qnil),
make_fixnum (cpu_gc_count),
result);
cpu_gc_count = 0;
next prev parent reply other threads:[~2023-03-10 18:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 12:24 bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node Mickey Petersen
2022-12-24 7:23 ` Eli Zaretskii
2022-12-24 9:20 ` Yuan Fu
2022-12-29 14:21 ` Mickey Petersen
2023-02-24 23:22 ` Yuan Fu
2023-02-25 7:13 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 7:51 ` Eli Zaretskii
2023-02-26 2:01 ` Yuan Fu
2023-02-26 2:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-26 6:18 ` Eli Zaretskii
2023-02-26 6:14 ` Eli Zaretskii
2023-02-26 15:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-28 14:00 ` Eli Zaretskii
2023-03-01 4:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-01 13:27 ` Eli Zaretskii
2023-03-01 14:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-01 15:51 ` Eli Zaretskii
2023-03-01 17:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 12:21 ` Eli Zaretskii
2023-03-08 16:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 18:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-03-10 20:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 6:45 ` Eli Zaretskii
2023-03-11 17:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 23:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 2:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 3:29 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 3:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 5:53 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 20:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-26 9:41 ` Mickey Petersen
2023-02-27 0:34 ` Yuan Fu
2023-02-27 8:22 ` Mickey Petersen
2023-02-27 9:05 ` Yuan Fu
2023-02-27 14:29 ` Mickey Petersen
2023-02-27 22:37 ` Yuan Fu
2023-02-27 22:45 ` Dmitry Gutov
2023-02-24 23:29 ` Yuan Fu
2023-02-25 7:55 ` Eli Zaretskii
2023-02-26 2:02 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7cvobiy4.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=60237@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=mickey@masteringemacs.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.